From: DJ Delorie <dj@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: MinGW compilation warnings in libiberty's include/environ.h
Date: Sat, 20 May 2017 01:25:00 -0000 [thread overview]
Message-ID: <xn37c0iajf.fsf@greed.delorie.com> (raw)
In-Reply-To: <83k25rcqw2.fsf@gnu.org> (message from Eli Zaretskii on Mon, 08 May 2017 18:25:17 +0300)
Fix committed. As Pedro noted, the correct way to request a change is
to make the change in your local checked out repo, and run "svn diff"
(or "git diff"). That makes sure that the fix is what you intended, and
that you don't have other unexpected changes (especially in regenerated
files, like configure). It also checks against a patch against a stale
copy of the sources; if your patch doesn't apply that's a hint to the
maintainer that the patch needs to be looked at more closely.
The easier you can make it for the maintainer (me!), the more likely
your patch will get handled quickly.
next prev parent reply other threads:[~2017-05-20 1:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 15:25 Eli Zaretskii
2017-05-19 15:51 ` Pedro Alves
2017-05-19 17:31 ` Eli Zaretskii
2017-05-20 1:27 ` DJ Delorie
2017-05-22 17:45 ` Pedro Alves
2017-05-20 1:25 ` DJ Delorie [this message]
2017-05-20 6:13 ` Eli Zaretskii
2017-05-20 6:16 ` DJ Delorie
2017-05-20 7:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xn37c0iajf.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=eliz@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox