From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8732 invoked by alias); 20 May 2017 01:25:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8700 invoked by uid 89); 20 May 2017 01:25:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=me! X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 20 May 2017 01:25:56 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 902F480468; Sat, 20 May 2017 01:25:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 902F480468 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 902F480468 Received: from greed.delorie.com (ovpn-120-43.rdu2.redhat.com [10.10.120.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E8C218341; Sat, 20 May 2017 01:25:58 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.14.7/8.14.7) with ESMTP id v4K1PuhK026401; Fri, 19 May 2017 21:25:56 -0400 From: DJ Delorie To: Eli Zaretskii Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Subject: Re: MinGW compilation warnings in libiberty's include/environ.h In-Reply-To: <83k25rcqw2.fsf@gnu.org> (message from Eli Zaretskii on Mon, 08 May 2017 18:25:17 +0300) Date: Sat, 20 May 2017 01:25:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00474.txt.bz2 Fix committed. As Pedro noted, the correct way to request a change is to make the change in your local checked out repo, and run "svn diff" (or "git diff"). That makes sure that the fix is what you intended, and that you don't have other unexpected changes (especially in regenerated files, like configure). It also checks against a patch against a stale copy of the sources; if your patch doesn't apply that's a hint to the maintainer that the patch needs to be looked at more closely. The easier you can make it for the maintainer (me!), the more likely your patch will get handled quickly.