From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: MinGW compilation warnings in libiberty's include/environ.h
Date: Fri, 19 May 2017 17:31:00 -0000 [thread overview]
Message-ID: <8360gw3g94.fsf@gnu.org> (raw)
In-Reply-To: <e7743e9f-2081-c730-bc57-144224690b1c@redhat.com> (message from Pedro Alves on Fri, 19 May 2017 16:51:30 +0100)
> Cc: gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Fri, 19 May 2017 16:51:30 +0100
>
> So again there's a system header that defines the symbol
> but for some reason libiberty still wants to declare/define
> it is if it weren't?
Yes. AFAICS, libiberty's configure script doesn't check the
declaration, it only probes the setenv function itself. You can see
that the cpp directives around the environ declarations are
OS-dependent rather than based on autoconf tests.
> That sounds to me like the root issue that should be fixed,
> so that these fallback definitions don't come into into play at all.
> I.e., why isn't HAVE_ENVIRON_DECL defined on mingw when
> setenv.o is built? Sounds like a decl check is missing
> in configure.ac.
Most probably, yes.
next prev parent reply other threads:[~2017-05-19 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 15:25 Eli Zaretskii
2017-05-19 15:51 ` Pedro Alves
2017-05-19 17:31 ` Eli Zaretskii [this message]
2017-05-20 1:27 ` DJ Delorie
2017-05-22 17:45 ` Pedro Alves
2017-05-20 1:25 ` DJ Delorie
2017-05-20 6:13 ` Eli Zaretskii
2017-05-20 6:16 ` DJ Delorie
2017-05-20 7:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8360gw3g94.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox