From: Daniel Berlin <dberlin@redhat.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: Michael Elizabeth Chastain <chastain@cygnus.com>,
gdb-patches@sources.redhat.com
Subject: Re: [PATCH] New C++ abstraction patch
Date: Wed, 21 Feb 2001 13:03:00 -0000 [thread overview]
Message-ID: <x7n1bfvje1.fsf@dynamic-addr-83-177.resnet.rochester.edu> (raw)
In-Reply-To: <3A940B9C.696ACE7B@cygnus.com>
Andrew Cagney <ac131313@cygnus.com> writes:
> Daniel Berlin wrote:
> >
> > Michael Elizabeth Chastain <chastain@cygnus.com> writes:
> >
> > > Hi Daniel,
> > >
> > > I have some comments on your patch.
> > >
> > > Michael
> > >
> > > ===
> > >
> > > + gnu-v3-abi.o: gnu-v3-abi.c cp-abi.h
> > > +
> > > + gnu-v2-abi.o: gnu-v2-abi.c cp-abi.h
> > > +
>
> FYI,
>
> The convention (and yes it is gross) is:
>
> cp-abi_h = cp-abi.h
> ....
> gnu-v3-abi.o: $(defs_h) $(cp-abi_h) ...
>
> (I think ``cp-abi_h'' is a valid Makefile macro). When things get
> converted to automake this will all go away.
>
I did this at first, but it seemed those only happened for certain
headers (something to do with $(SRCDIR)), so I undid it before
submitting the patch.
I'll redo it.
--Dan
next prev parent reply other threads:[~2001-02-21 13:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-20 17:35 Michael Elizabeth Chastain
2001-02-20 19:42 ` Daniel Berlin
2001-02-21 10:42 ` Andrew Cagney
2001-02-21 13:03 ` Daniel Berlin [this message]
2001-02-21 13:25 ` Andrew Cagney
2001-02-21 15:19 ` Michael Snyder
2001-02-22 8:14 ` Andrew Cagney
-- strict thread matches above, loose matches on Subject: below --
2001-02-21 7:43 Michael Elizabeth Chastain
2001-02-20 20:42 Michael Elizabeth Chastain
2001-02-20 23:42 ` Daniel Berlin
2001-02-21 11:53 ` Michael Snyder
2001-02-21 14:24 ` J.T. Conklin
2001-02-21 15:21 ` Michael Snyder
2001-02-20 16:02 Daniel Berlin
2001-02-21 1:53 ` Eli Zaretskii
2001-02-21 10:56 ` Andrew Cagney
2001-02-21 13:31 ` Daniel Berlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x7n1bfvje1.fsf@dynamic-addr-83-177.resnet.rochester.edu \
--to=dberlin@redhat.com \
--cc=ac131313@cygnus.com \
--cc=chastain@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox