From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Berlin To: Andrew Cagney Cc: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com Subject: Re: [PATCH] New C++ abstraction patch Date: Wed, 21 Feb 2001 13:03:00 -0000 Message-id: References: <200102210135.RAA21426@bosch.cygnus.com> <3A940B9C.696ACE7B@cygnus.com> X-SW-Source: 2001-02/msg00430.html Andrew Cagney writes: > Daniel Berlin wrote: > > > > Michael Elizabeth Chastain writes: > > > > > Hi Daniel, > > > > > > I have some comments on your patch. > > > > > > Michael > > > > > > === > > > > > > + gnu-v3-abi.o: gnu-v3-abi.c cp-abi.h > > > + > > > + gnu-v2-abi.o: gnu-v2-abi.c cp-abi.h > > > + > > FYI, > > The convention (and yes it is gross) is: > > cp-abi_h = cp-abi.h > .... > gnu-v3-abi.o: $(defs_h) $(cp-abi_h) ... > > (I think ``cp-abi_h'' is a valid Makefile macro). When things get > converted to automake this will all go away. > I did this at first, but it seemed those only happened for certain headers (something to do with $(SRCDIR)), so I undid it before submitting the patch. I'll redo it. --Dan