From: Jason Merrill <jason@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: trivial PATCH to dwarf2read.c:dwarf_attr_name
Date: Wed, 27 Aug 2003 16:45:00 -0000 [thread overview]
Message-ID: <wvlwucz59tl.fsf@prospero.boston.redhat.com> (raw)
In-Reply-To: <3F4CC452.1060100@redhat.com> (Andrew Cagney's message of "Wed, 27 Aug 2003 10:46:42 -0400")
On Wed, 27 Aug 2003 10:46:42 -0400, Andrew Cagney <ac131313@redhat.com> wrote:
>> On Tue, 26 Aug 2003 23:56:42 -0400, Andrew Cagney <ac131313@redhat.com> wrote:
>>
>>>> I'm checking this in under the obvious rule; DW_AT_MIPS_linkage_name is
>>>> used on all targets.
>>>> 2003-08-26 Jason Merrill <jason@redhat.com>
>>>> * dwarf2read.c (dwarf_attr_name): Move DW_AT_MIPS_linkage_name
>>>> case out of #ifdef MIPS block.
>>> Jason, exactly what prompted the change? In particular which GCC?
>> I don't remember. I think it's been in my local tree for years. It's
>> quite likely that I just noticed it.
>
> Can you please find out. There must be a stronger rationale then "it's
> been in my local tree for years".
The only rationale I have is that GCC emits DW_AT_MIPS_linkage_name on all
targets, so gdb should recognize it on all targets.
This isn't something that would affect normal operation--dwarf_attr_name is
only used by dump_die, which is only called when there's some sort of
internal error. I probably just noticed this in a grep for
DW_AT_MIPS_linkage_name while I was working on something else.
Jason
next prev parent reply other threads:[~2003-08-27 16:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-26 5:28 Jason Merrill
2003-08-27 3:56 ` Andrew Cagney
2003-08-27 4:44 ` Jason Merrill
2003-08-27 14:46 ` Andrew Cagney
2003-08-27 15:46 ` Daniel Jacobowitz
2003-08-27 15:57 ` Andrew Cagney
2003-08-27 16:02 ` Daniel Jacobowitz
2003-08-27 16:14 ` Andrew Cagney
2003-08-27 16:16 ` Daniel Jacobowitz
2003-08-27 19:37 ` Andrew Cagney
2003-08-27 16:45 ` Jason Merrill [this message]
2003-09-04 17:22 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wvlwucz59tl.fsf@prospero.boston.redhat.com \
--to=jason@redhat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox