From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6323 invoked by alias); 27 Aug 2003 16:45:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6314 invoked from network); 27 Aug 2003 16:45:09 -0000 Received: from unknown (HELO lacrosse.corp.redhat.com) (66.187.233.200) by sources.redhat.com with SMTP; 27 Aug 2003 16:45:09 -0000 Received: from prospero.boston.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221]) by lacrosse.corp.redhat.com (8.11.6/8.9.3) with ESMTP id h7RGj8K32279; Wed, 27 Aug 2003 12:45:08 -0400 Received: by prospero.boston.redhat.com (Postfix, from userid 4046) id 82A4EF7A5A; Wed, 27 Aug 2003 12:44:55 -0400 (EDT) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: trivial PATCH to dwarf2read.c:dwarf_attr_name From: Jason Merrill In-Reply-To: <3F4CC452.1060100@redhat.com> (Andrew Cagney's message of "Wed, 27 Aug 2003 10:46:42 -0400") References: <3F4C2BFA.9000108@redhat.com> <3F4CC452.1060100@redhat.com> Date: Wed, 27 Aug 2003 16:45:00 -0000 Message-ID: User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-08/txt/msg00479.txt.bz2 On Wed, 27 Aug 2003 10:46:42 -0400, Andrew Cagney wrote: >> On Tue, 26 Aug 2003 23:56:42 -0400, Andrew Cagney wrote: >> >>>> I'm checking this in under the obvious rule; DW_AT_MIPS_linkage_name is >>>> used on all targets. >>>> 2003-08-26 Jason Merrill >>>> * dwarf2read.c (dwarf_attr_name): Move DW_AT_MIPS_linkage_name >>>> case out of #ifdef MIPS block. >>> Jason, exactly what prompted the change? In particular which GCC? >> I don't remember. I think it's been in my local tree for years. It's >> quite likely that I just noticed it. > > Can you please find out. There must be a stronger rationale then "it's > been in my local tree for years". The only rationale I have is that GCC emits DW_AT_MIPS_linkage_name on all targets, so gdb should recognize it on all targets. This isn't something that would affect normal operation--dwarf_attr_name is only used by dump_die, which is only called when there's some sort of internal error. I probably just noticed this in a grep for DW_AT_MIPS_linkage_name while I was working on something else. Jason