Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Jason Merrill <jason@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: trivial PATCH to dwarf2read.c:dwarf_attr_name
Date: Wed, 27 Aug 2003 15:57:00 -0000	[thread overview]
Message-ID: <3F4CD4F5.9040302@redhat.com> (raw)
In-Reply-To: <20030827154638.GA17095@nevyn.them.org>

> Can you please find out.  There must be a stronger rationale then "it's 
>> been in my local tree for years".
> 
> 
> Well, the patch is certainly right.  GCC generates
> DW_AT_MIPS_linkage_name on all targets, and has for as far back as I
> have GCC sources to check it.

Can you please add a comment explaining exactly when/where this occures 
then?  Someone looking that that code is going to assume that 
DW_AT_MIPS_linkage_name is outside the #ifdef MIPS because of a 
host/target cross platform problem and _not_ because GCC uses it for all 
architectures.

Andrew



  reply	other threads:[~2003-08-27 15:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-26  5:28 Jason Merrill
2003-08-27  3:56 ` Andrew Cagney
2003-08-27  4:44   ` Jason Merrill
2003-08-27 14:46     ` Andrew Cagney
2003-08-27 15:46       ` Daniel Jacobowitz
2003-08-27 15:57         ` Andrew Cagney [this message]
2003-08-27 16:02           ` Daniel Jacobowitz
2003-08-27 16:14             ` Andrew Cagney
2003-08-27 16:16               ` Daniel Jacobowitz
2003-08-27 19:37                 ` Andrew Cagney
2003-08-27 16:45       ` Jason Merrill
2003-09-04 17:22         ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F4CD4F5.9040302@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox