Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* PATCH to testsuite/gdb.c++/userdef.cc
@ 2002-01-08  8:03 Jason Merrill
  2002-01-08 12:29 ` Andrew Cagney
  0 siblings, 1 reply; 5+ messages in thread
From: Jason Merrill @ 2002-01-08  8:03 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

This change allows the test to actually run (as expected), rather than see
a warning and give up.

I've gone ahead and checked this in; hope that's OK.

2002-01-08  Jason Merrill  <jason@redhat.com>

	* gdb.c++/userdef.cc: Use <iostream> instead of <iostream.h>.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 262 bytes --]

*** gdb.c++/userdef.cc.~1~	Fri Apr 16 02:34:32 1999
--- gdb.c++/userdef.cc	Tue Jan  8 15:15:05 2002
***************
*** 1,4 ****
! #include <iostream.h>
  
  void marker1()
  {
--- 1,6 ----
! #include <iostream>
! 
! using namespace std;
  
  void marker1()
  {

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: PATCH to testsuite/gdb.c++/userdef.cc
  2002-01-08  8:03 PATCH to testsuite/gdb.c++/userdef.cc Jason Merrill
@ 2002-01-08 12:29 ` Andrew Cagney
  2002-01-08 13:13   ` Jason Merrill
  0 siblings, 1 reply; 5+ messages in thread
From: Andrew Cagney @ 2002-01-08 12:29 UTC (permalink / raw)
  To: Jason Merrill; +Cc: gdb-patches


> I've gone ahead and checked this in; hope that's OK.


Not really.  You are not recognzied by the MAINTAINERS file.
Please don't do this again.

Andrew




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: PATCH to testsuite/gdb.c++/userdef.cc
  2002-01-08 12:29 ` Andrew Cagney
@ 2002-01-08 13:13   ` Jason Merrill
  2002-01-08 16:34     ` Andrew Cagney
  0 siblings, 1 reply; 5+ messages in thread
From: Jason Merrill @ 2002-01-08 13:13 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: gdb-patches

>>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:

>> I've gone ahead and checked this in; hope that's OK.

> Not really.

Sorry, I figured it would fall under the obvious fix rule.  But...

> You are not recognzied by the MAINTAINERS file.

Any objection to my being write-after-approval?  I don't do much gdb
hacking, but I've certainly had a few nontrivial patches accepted over the
years.

In any case, in the future I won't check anything in without prior
approval.

Jason


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: PATCH to testsuite/gdb.c++/userdef.cc
  2002-01-08 13:13   ` Jason Merrill
@ 2002-01-08 16:34     ` Andrew Cagney
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Cagney @ 2002-01-08 16:34 UTC (permalink / raw)
  To: Jason Merrill; +Cc: gdb-patches

> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
> 
> 
>>> I've gone ahead and checked this in; hope that's OK.
> 
> 
>> Not really.
> 
> 
> Sorry, I figured it would fall under the obvious fix rule.  But...


It would, if you were in the MAINTAINERS file.

In case you're wondering, getting write-after-approval access is pretty 
easy.  Just:

	o	submit a single good patch
		(suggest a one line indentation fix
		or even something removing a ``register''
		attribute from a declaration)

	o	have an assignment

enjoy,
Andrew



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: PATCH to testsuite/gdb.c++/userdef.cc
@ 2002-01-08  8:40 Michael Elizabeth Chastain
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Elizabeth Chastain @ 2002-01-08  8:40 UTC (permalink / raw)
  To: gdb-patches, jason

Oh, good, I've been hoping someone would submit that patch.

It's approved.  :)

Michael C


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2002-01-09  0:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-01-08  8:03 PATCH to testsuite/gdb.c++/userdef.cc Jason Merrill
2002-01-08 12:29 ` Andrew Cagney
2002-01-08 13:13   ` Jason Merrill
2002-01-08 16:34     ` Andrew Cagney
2002-01-08  8:40 Michael Elizabeth Chastain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox