Re: PATCH to testsuite/gdb.c++/userdef.cc

Re: PATCH to testsuite/gdb.c++/userdef.cc

[Michael Elizabeth Chastain]

Oh, good, I've been hoping someone would submit that patch.

It's approved.  :)

Michael C

PATCH to testsuite/gdb.c++/userdef.cc

[Jason Merrill]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

This change allows the test to actually run (as expected), rather than see
a warning and give up.

I've gone ahead and checked this in; hope that's OK.

2002-01-08  Jason Merrill  <jason@redhat.com>

	* gdb.c++/userdef.cc: Use <iostream> instead of <iostream.h>.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 262 bytes --]

*** gdb.c++/userdef.cc.~1~	Fri Apr 16 02:34:32 1999
--- gdb.c++/userdef.cc	Tue Jan  8 15:15:05 2002
***************
*** 1,4 ****
! #include <iostream.h>
  
  void marker1()
  {
--- 1,6 ----
! #include <iostream>
! 
! using namespace std;
  
  void marker1()
  {

Re: PATCH to testsuite/gdb.c++/userdef.cc

[Andrew Cagney]

> I've gone ahead and checked this in; hope that's OK.


Not really.  You are not recognzied by the MAINTAINERS file.
Please don't do this again.

Andrew

Re: PATCH to testsuite/gdb.c++/userdef.cc

[Jason Merrill]

>>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:

>> I've gone ahead and checked this in; hope that's OK.

> Not really.

Sorry, I figured it would fall under the obvious fix rule.  But...

> You are not recognzied by the MAINTAINERS file.

Any objection to my being write-after-approval?  I don't do much gdb
hacking, but I've certainly had a few nontrivial patches accepted over the
years.

In any case, in the future I won't check anything in without prior
approval.

Jason

Re: PATCH to testsuite/gdb.c++/userdef.cc

[Andrew Cagney]

> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
> 
> 
>>> I've gone ahead and checked this in; hope that's OK.
> 
> 
>> Not really.
> 
> 
> Sorry, I figured it would fall under the obvious fix rule.  But...


It would, if you were in the MAINTAINERS file.

In case you're wondering, getting write-after-approval access is pretty 
easy.  Just:

	o	submit a single good patch
		(suggest a one line indentation fix
		or even something removing a ``register''
		attribute from a declaration)

	o	have an assignment

enjoy,
Andrew