From: Jim Blandy <jimb@redhat.com>
To: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
Cc: gdb-patches@sources.redhat.com, uweigand@de.ibm.com
Subject: Re: [PATCH] S/390 port modernization 1/4
Date: Thu, 04 Dec 2003 21:01:00 -0000 [thread overview]
Message-ID: <vt2zne8z4bn.fsf@zenia.home> (raw)
In-Reply-To: <200312042006.VAA07701@faui1d.informatik.uni-erlangen.de>
Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de> writes:
> *** gdb-head/gdb/config/s390/tm-linux.h Tue Dec 2 17:47:36 2003
> --- gdb-head-new/gdb/config/s390/tm-linux.h Tue Dec 2 16:36:15 2003
> ***************
> *** 25,42 ****
> #ifndef TM_LINUX_H
> #define TM_LINUX_H
>
> - #undef TARGET_ELF64
> - #define TARGET_ELF64 (gdbarch_tdep (current_gdbarch)->intreg_size==8)
> -
> #include "config/tm-linux.h"
>
> - /* Zap several macros defined in the above header so that multi-arch
> - can safely re-define them. The ``correct fix'' involves
> - eliminating either the above include or even this file. */
> - #undef SKIP_TRAMPOLINE_CODE
> -
> - #include "s390/tm-s390.h"
> -
> -
> -
> #endif /* TM_LINUX_H */
> --- 25,30 ----
The deletion of the #undefinition of SKIP_TRAMPOLINE_CODE isn't
mentioned in the ChangeLog entries; was it intentional? If I'm
following the code right, the effect is to change the method from
using generic_skip_trampoline_code (the gdbarch default) to using
find_solib_trampoline_target (#defined in config/tm-sysv4.h, #included
from config/tm-linux.h, #included from config/s390/tm-linux.h), so it
seems like something that deserves mention.
next prev parent reply other threads:[~2003-12-04 21:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-04 20:06 Ulrich Weigand
2003-12-04 21:01 ` Jim Blandy [this message]
2003-12-04 21:56 ` Ulrich Weigand
2003-12-05 4:21 ` Jim Blandy
2003-12-04 21:18 ` Jim Blandy
2003-12-04 21:45 ` Ulrich Weigand
2003-12-05 4:29 ` Jim Blandy
2003-12-04 21:43 ` Jim Blandy
2003-12-04 22:11 ` Ulrich Weigand
2003-12-05 4:30 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2zne8z4bn.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=uweigand@de.ibm.com \
--cc=weigand@i1.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox