From: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
To: jimb@redhat.com (Jim Blandy)
Cc: weigand@i1.informatik.uni-erlangen.de (Ulrich Weigand),
gdb-patches@sources.redhat.com, uweigand@de.ibm.com
Subject: Re: [PATCH] S/390 port modernization 1/4
Date: Thu, 04 Dec 2003 21:56:00 -0000 [thread overview]
Message-ID: <200312042156.WAA07865@faui1d.informatik.uni-erlangen.de> (raw)
In-Reply-To: <vt2zne8z4bn.fsf@zenia.home> from "Jim Blandy" at Dec 04, 2003 04:00:12 PM
Jim Blandy wrote:
> The deletion of the #undefinition of SKIP_TRAMPOLINE_CODE isn't
> mentioned in the ChangeLog entries; was it intentional? If I'm
> following the code right, the effect is to change the method from
> using generic_skip_trampoline_code (the gdbarch default) to using
> find_solib_trampoline_target (#defined in config/tm-sysv4.h, #included
> from config/tm-linux.h, #included from config/s390/tm-linux.h), so it
> seems like something that deserves mention.
Hmm, I probably misinterpreted the comment above that line ...
In any case, looking at the code, it certainly seems the right
thing to do to use the same SKIP_TRAMPOLINE_CODE as other Linux
ports, since everything related to PLTs works the same on s390
as elsewhere.
So I'd suggest to leave the patch as is in that regard, and simply
add a ChangeLog line.
Bye,
Ulrich
--
Dr. Ulrich Weigand
weigand@informatik.uni-erlangen.de
next prev parent reply other threads:[~2003-12-04 21:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-04 20:06 Ulrich Weigand
2003-12-04 21:01 ` Jim Blandy
2003-12-04 21:56 ` Ulrich Weigand [this message]
2003-12-05 4:21 ` Jim Blandy
2003-12-04 21:18 ` Jim Blandy
2003-12-04 21:45 ` Ulrich Weigand
2003-12-05 4:29 ` Jim Blandy
2003-12-04 21:43 ` Jim Blandy
2003-12-04 22:11 ` Ulrich Weigand
2003-12-05 4:30 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200312042156.WAA07865@faui1d.informatik.uni-erlangen.de \
--to=weigand@i1.informatik.uni-erlangen.de \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox