From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15619 invoked by alias); 4 Dec 2003 21:56:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15612 invoked from network); 4 Dec 2003 21:56:24 -0000 Received: from unknown (HELO faui10.informatik.uni-erlangen.de) (131.188.31.10) by sources.redhat.com with SMTP; 4 Dec 2003 21:56:24 -0000 Received: from faui1d.informatik.uni-erlangen.de (faui1d [131.188.31.34]) by faui10.informatik.uni-erlangen.de (8.9.3p3/8.1.9-FAU) with ESMTP id WAA23843; Thu, 4 Dec 2003 22:56:19 +0100 (CET) From: Ulrich Weigand Received: (from weigand@localhost) by faui1d.informatik.uni-erlangen.de (8.9.3p3/8.1.6-FAU) id WAA07865; Thu, 4 Dec 2003 22:56:19 +0100 (CET) Message-Id: <200312042156.WAA07865@faui1d.informatik.uni-erlangen.de> Subject: Re: [PATCH] S/390 port modernization 1/4 To: jimb@redhat.com (Jim Blandy) Date: Thu, 04 Dec 2003 21:56:00 -0000 Cc: weigand@i1.informatik.uni-erlangen.de (Ulrich Weigand), gdb-patches@sources.redhat.com, uweigand@de.ibm.com In-Reply-To: from "Jim Blandy" at Dec 04, 2003 04:00:12 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00147.txt.bz2 Jim Blandy wrote: > The deletion of the #undefinition of SKIP_TRAMPOLINE_CODE isn't > mentioned in the ChangeLog entries; was it intentional? If I'm > following the code right, the effect is to change the method from > using generic_skip_trampoline_code (the gdbarch default) to using > find_solib_trampoline_target (#defined in config/tm-sysv4.h, #included > from config/tm-linux.h, #included from config/s390/tm-linux.h), so it > seems like something that deserves mention. Hmm, I probably misinterpreted the comment above that line ... In any case, looking at the code, it certainly seems the right thing to do to use the same SKIP_TRAMPOLINE_CODE as other Linux ports, since everything related to PLTs works the same on s390 as elsewhere. So I'd suggest to leave the patch as is in that regard, and simply add a ChangeLog line. Bye, Ulrich -- Dr. Ulrich Weigand weigand@informatik.uni-erlangen.de