From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-29108-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 6670 invoked by alias); 4 Dec 2003 21:01:49 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 6638 invoked from network); 4 Dec 2003 21:01:48 -0000
Received: from unknown (HELO zenia.home) (12.223.225.216)
  by sources.redhat.com with SMTP; 4 Dec 2003 21:01:48 -0000
Received: by zenia.home (Postfix, from userid 5433)
	id 1763620766; Thu,  4 Dec 2003 16:00:12 -0500 (EST)
To: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
Cc: gdb-patches@sources.redhat.com, uweigand@de.ibm.com
Subject: Re: [PATCH] S/390 port modernization 1/4
References: <200312042006.VAA07701@faui1d.informatik.uni-erlangen.de>
From: Jim Blandy <jimb@redhat.com>
Date: Thu, 04 Dec 2003 21:01:00 -0000
In-Reply-To: <200312042006.VAA07701@faui1d.informatik.uni-erlangen.de>
Message-ID: <vt2zne8z4bn.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2003-12/txt/msg00137.txt.bz2


Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de> writes:
> *** gdb-head/gdb/config/s390/tm-linux.h	Tue Dec  2 17:47:36 2003
> --- gdb-head-new/gdb/config/s390/tm-linux.h	Tue Dec  2 16:36:15 2003
> ***************
> *** 25,42 ****
>   #ifndef TM_LINUX_H
>   #define TM_LINUX_H
>   
> - #undef  TARGET_ELF64
> - #define TARGET_ELF64 (gdbarch_tdep (current_gdbarch)->intreg_size==8)
> - 
>   #include "config/tm-linux.h"
>   
> - /* Zap several macros defined in the above header so that multi-arch
> -    can safely re-define them.  The ``correct fix'' involves
> -    eliminating either the above include or even this file.  */
> - #undef SKIP_TRAMPOLINE_CODE
> - 
> - #include "s390/tm-s390.h"
> - 
> - 
> - 
>   #endif /* TM_LINUX_H */
> --- 25,30 ----

The deletion of the #undefinition of SKIP_TRAMPOLINE_CODE isn't
mentioned in the ChangeLog entries; was it intentional?  If I'm
following the code right, the effect is to change the method from
using generic_skip_trampoline_code (the gdbarch default) to using
find_solib_trampoline_target (#defined in config/tm-sysv4.h, #included
from config/tm-linux.h, #included from config/s390/tm-linux.h), so it
seems like something that deserves mention.