Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: kevinb@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix small problems in rs6000-tdep.c:skip_prologue()
Date: Fri, 14 May 2004 22:18:00 -0000	[thread overview]
Message-ID: <vt2r7tmlkjs.fsf@zenia.home> (raw)
In-Reply-To: <20040508001600.GH16083@gnat.com>

> > Attached is a revised version incorporating your changes. Could you
> > give it a shot against your function, and let me know if it works for
> > you? It works for me, and doesn't introduce any regression on our
> > powerpc-aix-5.1 machine.
> > 
> > 2004-04-16  Joel Brobecker  <brobecker@gnat.com>
> > 
> >         * rs6000-tdep.c (store_param_on_stack_p): New function,
> >         an improved version of some code extracted from skip_prologue().
> >         (skip_prologue): Use store_param_on_stack_p() to detect
> >         instructions saving a parameter on the stack. Detect when r0
> >         is used to save a parameter.
> >         Do not mark "li rx, SIMM" instructions as part of the prologue,
> >         unless the following instruction is also part of the prologue.
> >         
> > I'll followup with a testcase soon.

I've finally been able to give this a shot, and it works fine on my
prologue, too.  So I have no objections to the patch.  Thanks for your
patience, Joel!

I've got a test script now for PPC E500 prologues, which I'll post
under separate cover.


  parent reply	other threads:[~2004-05-14 22:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-02 18:36 Joel Brobecker
2004-04-02 21:15 ` Jim Blandy
2004-04-03 14:17   ` Kevin Buettner
2004-04-03 21:06     ` Jim Blandy
2004-04-17  5:15   ` Joel Brobecker
2004-04-17 14:39     ` Daniel Jacobowitz
2004-04-19 12:42       ` Jim Blandy
2004-04-19 13:22         ` Daniel Jacobowitz
2004-04-19 17:53       ` Joel Brobecker
2004-04-19 18:06         ` Daniel Jacobowitz
2004-04-19 18:08         ` Jim Blandy
2004-04-19 18:24           ` Jim Blandy
     [not found]     ` <20040508001600.GH16083@gnat.com>
2004-05-14 22:18       ` Jim Blandy [this message]
     [not found]         ` <20040514170539.4727eec9@saguaro>
2004-05-15  6:00           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2r7tmlkjs.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox