From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Blandy To: Joel Brobecker Cc: kevinb@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix small problems in rs6000-tdep.c:skip_prologue() Date: Fri, 14 May 2004 22:18:00 -0000 Message-id: References: <20040402183637.GC871@gnat.com> <20040417051545.GO22414@gnat.com> <20040508001600.GH16083@gnat.com> X-SW-Source: 2004-05/msg00435.html > > Attached is a revised version incorporating your changes. Could you > > give it a shot against your function, and let me know if it works for > > you? It works for me, and doesn't introduce any regression on our > > powerpc-aix-5.1 machine. > > > > 2004-04-16 Joel Brobecker > > > > * rs6000-tdep.c (store_param_on_stack_p): New function, > > an improved version of some code extracted from skip_prologue(). > > (skip_prologue): Use store_param_on_stack_p() to detect > > instructions saving a parameter on the stack. Detect when r0 > > is used to save a parameter. > > Do not mark "li rx, SIMM" instructions as part of the prologue, > > unless the following instruction is also part of the prologue. > > > > I'll followup with a testcase soon. I've finally been able to give this a shot, and it works fine on my prologue, too. So I have no objections to the patch. Thanks for your patience, Joel! I've got a test script now for PPC E500 prologues, which I'll post under separate cover.