Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Joel Brobecker <brobecker@gnat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix small problems in rs6000-tdep.c:skip_prologue()
Date: Mon, 19 Apr 2004 12:42:00 -0000	[thread overview]
Message-ID: <vt2pta4xzrn.fsf@zenia.home> (raw)
In-Reply-To: <20040417143940.GA7428@nevyn.them.org>


Daniel Jacobowitz <drow@false.org> writes:
> On Fri, Apr 16, 2004 at 10:15:45PM -0700, Joel Brobecker wrote:
> > > In this case, the stX 0,N(31) is spilling an argument, even though r0
> > > is not an argument register.  ('evstdd' is an E500 instruction that
> > > is definitely an argument spill.)
> > 
> > Dough!
> > 
> > > Clearly, both your function and mine need to go into the test suite...
> > 
> > I can add a new testcase in Ada for the prologue we saw.
> 
> I'd prefer that you add them to gdb.asm, unless it's likely to produce
> strange prologues on other architectures.  That way you can test what
> you're trying to test, instead of something different.  For instance,
> once dwarf2 unwinding is switched on for PPC, an Ada testcase is likely
> to not trigger most of the prologue scanning.

I totally agree.  Prologue analysis failures are a major part of
stabilizing a GDB port, at least for me.  I've never actually dumped
the exact prologues I've got on hand into a test script, but it seems
like the obvious thing to do.  Is there some reason we don't already?


  reply	other threads:[~2004-04-19 12:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-02 18:36 Joel Brobecker
2004-04-02 21:15 ` Jim Blandy
2004-04-03 14:17   ` Kevin Buettner
2004-04-03 21:06     ` Jim Blandy
2004-04-17  5:15   ` Joel Brobecker
2004-04-17 14:39     ` Daniel Jacobowitz
2004-04-19 12:42       ` Jim Blandy [this message]
2004-04-19 13:22         ` Daniel Jacobowitz
2004-04-19 17:53       ` Joel Brobecker
2004-04-19 18:06         ` Daniel Jacobowitz
2004-04-19 18:08         ` Jim Blandy
2004-04-19 18:24           ` Jim Blandy
     [not found]     ` <20040508001600.GH16083@gnat.com>
2004-05-14 22:18       ` Jim Blandy
     [not found]         ` <20040514170539.4727eec9@saguaro>
2004-05-15  6:00           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2pta4xzrn.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=brobecker@gnat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox