From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19768 invoked by alias); 19 Apr 2004 12:42:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19602 invoked from network); 19 Apr 2004 12:42:40 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 19 Apr 2004 12:42:40 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3JCgeJW031758 for ; Mon, 19 Apr 2004 08:42:40 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3J6FJj28404; Mon, 19 Apr 2004 02:15:20 -0400 To: Daniel Jacobowitz Cc: Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix small problems in rs6000-tdep.c:skip_prologue() References: <20040402183637.GC871@gnat.com> <20040417051545.GO22414@gnat.com> <20040417143940.GA7428@nevyn.them.org> From: Jim Blandy Date: Mon, 19 Apr 2004 12:42:00 -0000 In-Reply-To: <20040417143940.GA7428@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-04/txt/msg00418.txt.bz2 Daniel Jacobowitz writes: > On Fri, Apr 16, 2004 at 10:15:45PM -0700, Joel Brobecker wrote: > > > In this case, the stX 0,N(31) is spilling an argument, even though r0 > > > is not an argument register. ('evstdd' is an E500 instruction that > > > is definitely an argument spill.) > > > > Dough! > > > > > Clearly, both your function and mine need to go into the test suite... > > > > I can add a new testcase in Ada for the prologue we saw. > > I'd prefer that you add them to gdb.asm, unless it's likely to produce > strange prologues on other architectures. That way you can test what > you're trying to test, instead of something different. For instance, > once dwarf2 unwinding is switched on for PPC, an Ada testcase is likely > to not trigger most of the prologue scanning. I totally agree. Prologue analysis failures are a major part of stabilizing a GDB port, at least for me. I've never actually dumped the exact prologues I've got on hand into a test script, but it seems like the obvious thing to do. Is there some reason we don't already?