Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: PATCH: correctly place new inclusions in includer's list
Date: Mon, 22 Sep 2003 18:00:00 -0000	[thread overview]
Message-ID: <vt2pthsemeu.fsf@zenia.home> (raw)
In-Reply-To: <vt2u178fo22.fsf@zenia.home>


I think this would be good to include on the 6.0 branch; would that be okay?

Jim Blandy <jimb@redhat.com> writes:

> D'oh.
> 
> 2003-09-19  Jim Blandy  <jimb@redhat.com>
> 
> 	* macrotab.c (macro_include): Use the correct comparison to find
> 	the appropriate place for this inclusion in the list.
> 
> Index: gdb/macrotab.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/macrotab.c,v
> retrieving revision 1.8
> diff -c -r1.8 macrotab.c
> *** gdb/macrotab.c	8 Jun 2003 18:27:14 -0000	1.8
> --- gdb/macrotab.c	19 Sep 2003 21:39:51 -0000
> ***************
> *** 426,436 ****
>     struct macro_source_file **link;
>   
>     /* Find the right position in SOURCE's `includes' list for the new
> !      file.  Scan until we find the first file we shouldn't follow ---
> !      which is therefore the file we should directly precede --- or
> !      reach the end of the list.  */
>     for (link = &source->includes;
> !        *link && line < (*link)->included_at_line;
>          link = &(*link)->next_included)
>       ;
>   
> --- 426,435 ----
>     struct macro_source_file **link;
>   
>     /* Find the right position in SOURCE's `includes' list for the new
> !      file.  Skip inclusions at earlier lines, until we find one at the
> !      same line or later --- or until the end of the list.  */
>     for (link = &source->includes;
> !        *link && (*link)->included_at_line < line;
>          link = &(*link)->next_included)
>       ;
>   


  reply	other threads:[~2003-09-22 18:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-19 21:50 Jim Blandy
2003-09-22 18:00 ` Jim Blandy [this message]
2003-09-22 18:06   ` David Carlton
2003-09-22 18:28     ` Andrew Cagney
2003-09-22 22:28       ` Jim Blandy
2003-09-22 19:42     ` Jim Blandy
2003-09-22 20:11       ` David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2pthsemeu.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox