From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13417 invoked by alias); 22 Sep 2003 18:00:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13410 invoked from network); 22 Sep 2003 18:00:42 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 22 Sep 2003 18:00:42 -0000 Received: by zenia.home (Postfix, from userid 5433) id CF5AD2075E; Mon, 22 Sep 2003 12:57:29 -0500 (EST) To: gdb-patches@sources.redhat.com Subject: Re: PATCH: correctly place new inclusions in includer's list References: From: Jim Blandy Date: Mon, 22 Sep 2003 18:00:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-09/txt/msg00475.txt.bz2 I think this would be good to include on the 6.0 branch; would that be okay? Jim Blandy writes: > D'oh. > > 2003-09-19 Jim Blandy > > * macrotab.c (macro_include): Use the correct comparison to find > the appropriate place for this inclusion in the list. > > Index: gdb/macrotab.c > =================================================================== > RCS file: /cvs/src/src/gdb/macrotab.c,v > retrieving revision 1.8 > diff -c -r1.8 macrotab.c > *** gdb/macrotab.c 8 Jun 2003 18:27:14 -0000 1.8 > --- gdb/macrotab.c 19 Sep 2003 21:39:51 -0000 > *************** > *** 426,436 **** > struct macro_source_file **link; > > /* Find the right position in SOURCE's `includes' list for the new > ! file. Scan until we find the first file we shouldn't follow --- > ! which is therefore the file we should directly precede --- or > ! reach the end of the list. */ > for (link = &source->includes; > ! *link && line < (*link)->included_at_line; > link = &(*link)->next_included) > ; > > --- 426,435 ---- > struct macro_source_file **link; > > /* Find the right position in SOURCE's `includes' list for the new > ! file. Skip inclusions at earlier lines, until we find one at the > ! same line or later --- or until the end of the list. */ > for (link = &source->includes; > ! *link && (*link)->included_at_line < line; > link = &(*link)->next_included) > ; >