From: Jim Blandy <jimb@redhat.com>
To: David Lecomber <david@streamline-computing.com>
Cc: patches <gdb-patches@sources.redhat.com>
Subject: Re: [PATCH/RFA] PR gdb/648
Date: Wed, 18 Aug 2004 16:36:00 -0000 [thread overview]
Message-ID: <vt2llgcbe64.fsf@zenia.home> (raw)
In-Reply-To: <1092659964.5816.5.camel@localhost>
Thanks for the revisions!
Any reason read_array_ordering can't return 'enum
dwarf_array_dim_ordering' instead of 'int'?
The special case for GNU F77 needs a comment --- just explaining that
F77 does things backwards as of Aug 2004, etc. etc. Basically what
you said in your original post, explaining why the special case was
necessary.
With those changes, the dwarf2read.c portions of this change are
approved. So I think the eval.c stuff is all that's left for someone
to review.
next prev parent reply other threads:[~2004-08-18 16:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-06 22:10 David Lecomber
2004-08-13 10:25 ` David Lecomber
2004-08-13 10:32 ` Michael Chastain
2004-08-13 22:14 ` Jim Blandy
2004-08-16 12:33 ` David Lecomber
2004-08-16 12:38 ` David Lecomber
2004-08-18 16:36 ` Jim Blandy [this message]
2004-08-20 13:37 ` [PATCH/RFA] PR gdb/648 (eval.c approval reqd) David Lecomber
2004-08-20 13:45 ` David Lecomber
2004-08-25 5:53 ` Jim Blandy
2004-08-25 7:24 ` David Lecomber
2004-08-27 0:00 ` Jim Blandy
2004-08-27 9:15 ` David Lecomber
2004-08-27 13:52 ` Andrew Cagney
2004-08-27 13:58 ` Michael Chastain
2004-08-27 14:14 ` Andrew Cagney
2004-08-27 14:57 ` Michael Chastain
2004-08-27 15:57 ` Andrew Cagney
2004-08-27 16:15 ` Michael Chastain
2004-08-30 14:17 ` Andrew Cagney
2004-08-23 19:26 ` [PATCH/RFA] PR gdb/648 Andrew Cagney
2004-08-24 18:03 ` Jim Blandy
2004-08-15 8:19 ` Michael Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2llgcbe64.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=david@streamline-computing.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox