From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6379 invoked by alias); 18 Aug 2004 16:36:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6246 invoked from network); 18 Aug 2004 16:36:41 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 18 Aug 2004 16:36:41 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7IGaUe1012034 for ; Wed, 18 Aug 2004 12:36:40 -0400 Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7IGaNa24287; Wed, 18 Aug 2004 12:36:24 -0400 To: David Lecomber Cc: patches Subject: Re: [PATCH/RFA] PR gdb/648 References: <1091830216.4188.23.camel@localhost> <1092659964.5816.5.camel@localhost> From: Jim Blandy Date: Wed, 18 Aug 2004 16:36:00 -0000 In-Reply-To: <1092659964.5816.5.camel@localhost> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-08/txt/msg00561.txt.bz2 Thanks for the revisions! Any reason read_array_ordering can't return 'enum dwarf_array_dim_ordering' instead of 'int'? The special case for GNU F77 needs a comment --- just explaining that F77 does things backwards as of Aug 2004, etc. etc. Basically what you said in your original post, explaining why the special case was necessary. With those changes, the dwarf2read.c portions of this change are approved. So I think the eval.c stuff is all that's left for someone to review.