Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Recognize 'x' in response to 'p' packet
Date: Tue, 28 Dec 2004 13:15:00 -0000	[thread overview]
Message-ID: <vt2d5wuvlkd.fsf@zenia.home> (raw)
In-Reply-To: <20041223171214.GA14604@nevyn.them.org>

Daniel Jacobowitz <drow@false.org> writes:

> On Thu, Dec 23, 2004 at 11:25:51AM -0500, Jim Blandy wrote:
> > Jim Blandy <jimb@redhat.com> writes:
> > 
> > > Daniel Jacobowitz <drow@false.org> writes:
> > > > My real question, though, is what you needed this for - and whether
> > > > marking the register unavailable fixes it.
> > > 
> > > The Red Hat Debug Agent generates replies to 'p' packets that contain
> > > 'x's.  GDB generally seems to work, but 'info thread' fares poorly.
> > > Simply parsing the response at all should fix the problem; I'll make
> > > sure that marking the register as unavailable doesn't cause any new
> > > problems.
> > > 
> > > Thanks for the review!
> > 
> > Okay, here's the revised patch, against the properly re-indented
> > sources.  Tested against RDA.
> > 
> > 2004-12-17  Jim Blandy  <jimb@redhat.com>
> > 
> > 	* remote.c (fetch_register_using_p): Recognize a register value
> > 	starting with 'x' as indicating an unfetchable register.
> 
> OK, thanks!  I will be getting around to adding 'p' to gdbserver soon,
> so I'll need this too.

Committed --- thanks for the review.


  reply	other threads:[~2004-12-28  9:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-03  0:22 Jim Blandy
2004-12-16 21:35 ` Jim Blandy
2004-12-17 22:20   ` Daniel Jacobowitz
2004-12-17 22:45     ` Jim Blandy
2004-12-18  1:24       ` Daniel Jacobowitz
2004-12-21 21:30         ` Jim Blandy
2004-12-23 16:43           ` Jim Blandy
2004-12-23 17:22             ` Daniel Jacobowitz
2004-12-28 13:15               ` Jim Blandy [this message]
2004-12-03  1:29 Paul Schlie
2004-12-03  4:32 ` Steven Johnson
2004-12-03  4:54   ` Paul Schlie
2004-12-03 13:57     ` Daniel Jacobowitz
2004-12-03 21:48       ` Michael Snyder
2004-12-03 21:45 ` Michael Snyder
2004-12-03 22:53   ` Paul Schlie
2004-12-03 23:44     ` Paul Schlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2d5wuvlkd.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox