From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-37613-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 24303 invoked by alias); 28 Dec 2004 09:10:03 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24061 invoked from network); 28 Dec 2004 09:09:51 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 28 Dec 2004 09:09:51 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iBS99pTd014927
	for <gdb-patches@sources.redhat.com>; Tue, 28 Dec 2004 04:09:51 -0500
Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBS99nr19182;
	Tue, 28 Dec 2004 04:09:50 -0500
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Recognize 'x' in response to 'p' packet
References: <vt2mzww8c2z.fsf@zenia.home> <vt2wtvilzhb.fsf@zenia.home>
	<20041217193240.GA19185@nevyn.them.org> <vt2oegslfis.fsf@zenia.home>
	<20041217224540.GA1084@nevyn.them.org> <vt2mzw7jqbh.fsf@zenia.home>
	<vt2ekhhhtgw.fsf@zenia.home> <20041223171214.GA14604@nevyn.them.org>
From: Jim Blandy <jimb@redhat.com>
Date: Tue, 28 Dec 2004 13:15:00 -0000
In-Reply-To: <20041223171214.GA14604@nevyn.them.org>
Message-ID: <vt2d5wuvlkd.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-12/txt/msg00448.txt.bz2

Daniel Jacobowitz <drow@false.org> writes:

> On Thu, Dec 23, 2004 at 11:25:51AM -0500, Jim Blandy wrote:
> > Jim Blandy <jimb@redhat.com> writes:
> > 
> > > Daniel Jacobowitz <drow@false.org> writes:
> > > > My real question, though, is what you needed this for - and whether
> > > > marking the register unavailable fixes it.
> > > 
> > > The Red Hat Debug Agent generates replies to 'p' packets that contain
> > > 'x's.  GDB generally seems to work, but 'info thread' fares poorly.
> > > Simply parsing the response at all should fix the problem; I'll make
> > > sure that marking the register as unavailable doesn't cause any new
> > > problems.
> > > 
> > > Thanks for the review!
> > 
> > Okay, here's the revised patch, against the properly re-indented
> > sources.  Tested against RDA.
> > 
> > 2004-12-17  Jim Blandy  <jimb@redhat.com>
> > 
> > 	* remote.c (fetch_register_using_p): Recognize a register value
> > 	starting with 'x' as indicating an unfetchable register.
> 
> OK, thanks!  I will be getting around to adding 'p' to gdbserver soon,
> so I'll need this too.

Committed --- thanks for the review.