Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Recognize 'x' in response to 'p' packet
Date: Sat, 18 Dec 2004 01:24:00 -0000	[thread overview]
Message-ID: <20041217224540.GA1084@nevyn.them.org> (raw)
In-Reply-To: <vt2oegslfis.fsf@zenia.home>

On Fri, Dec 17, 2004 at 05:35:23PM -0500, Jim Blandy wrote:
> Daniel Jacobowitz <drow@false.org> writes:
> > I know this came up a bit already, but could you elaborate on why you
> > had to silently provide a value of 0?  We do have a defined interface
> > for 'currently not available', though we do not use it well.  This
> > isn't support for the xx response, just a workaround.
> 
> I just missed it.  Is this (untested!) what you're looking for?
> 
> 2004-12-17  Jim Blandy  <jimb@redhat.com>
> 
> 	* remote.c (fetch_register_using_p): Recognize a register value
> 	starting with 'x' as indicating an unfetchable register.

More or less.  Spelling, formatting, and the fallthrough here:

> !   /* If this register is unfetchable, tell the regcache.  */
> !   if (buf[0] == 'x')
> !     {
> !       regcache_raw_supply (current_regcache, regnum, NULL);
> !       set_register_cached (regnum, -1);

          return <something>;

>       }
>   
> !   /* Otherwise, parse and supply the value.  */

My real question, though, is what you needed this for - and whether
marking the register unavailable fixes it.

-- 
Daniel Jacobowitz


  reply	other threads:[~2004-12-17 22:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-03  0:22 Jim Blandy
2004-12-16 21:35 ` Jim Blandy
2004-12-17 22:20   ` Daniel Jacobowitz
2004-12-17 22:45     ` Jim Blandy
2004-12-18  1:24       ` Daniel Jacobowitz [this message]
2004-12-21 21:30         ` Jim Blandy
2004-12-23 16:43           ` Jim Blandy
2004-12-23 17:22             ` Daniel Jacobowitz
2004-12-28 13:15               ` Jim Blandy
2004-12-03  1:29 Paul Schlie
2004-12-03  4:32 ` Steven Johnson
2004-12-03  4:54   ` Paul Schlie
2004-12-03 13:57     ` Daniel Jacobowitz
2004-12-03 21:48       ` Michael Snyder
2004-12-03 21:45 ` Michael Snyder
2004-12-03 22:53   ` Paul Schlie
2004-12-03 23:44     ` Paul Schlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041217224540.GA1084@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox