Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Michael Snyder <msnyder@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: RFA: remote.c: parse thread ID's as unsigned values
Date: Tue, 07 Dec 2004 20:26:00 -0000	[thread overview]
Message-ID: <vt23byh507t.fsf@zenia.home> (raw)
In-Reply-To: <20041203223050.GA15548@nevyn.them.org>


Daniel Jacobowitz <drow@false.org> writes:
> On Fri, Dec 03, 2004 at 01:48:12PM -0800, Michael Snyder wrote:
> > Jim Blandy wrote:
> > >One month ping.
> > 
> > Well heck, I'm not the remote.c maintainer, but I'm the thread
> > maintainer (or one of them).
> > 
> > Your change certainly seems reasonable to me.  Can't think why
> > we would want thread ids to be sign extended...
> > 
> > Under the assumption that you've run into a situation where this
> > is applicable, and the change tests out well, I'll give it the nod.
> 
> Fine by me too - but if the manual is unclear, Jim, could you clarify
> it?

I've committed the patch, thanks.  How's this for the documentation
change?

2004-12-07  Jim Blandy  <jimb@redhat.com>

	* gdb.texinfo (General Query Packets): Specify that thread ID's in
	the 'qC' and 'qThreadInfo' packets are unsigned hexidecimal
	numbers.

Index: gdb/doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.228
diff -c -p -r1.228 gdb.texinfo
*** gdb/doc/gdb.texinfo	7 Dec 2004 11:06:04 -0000	1.228
--- gdb/doc/gdb.texinfo	7 Dec 2004 20:14:33 -0000
*************** Return the current thread id.
*** 20834,20840 ****
  Reply:
  @table @samp
  @item @code{QC}@var{pid}
! Where @var{pid} is a HEX encoded 16 bit process id.
  @item *
  Any other reply implies the old pid.
  @end table
--- 20834,20840 ----
  Reply:
  @table @samp
  @item @code{QC}@var{pid}
! Where @var{pid} is an unsigned hexidecimal process id.
  @item *
  Any other reply implies the old pid.
  @end table
*************** a comma-separated list of thread ids
*** 20863,20872 ****
  @end table
  
  In response to each query, the target will reply with a list of one or
! more thread ids, in big-endian hex, separated by commas.  @value{GDBN}
! will respond to each reply with a request for more thread ids (using the
! @code{qs} form of the query), until the target responds with @code{l}
! (lower-case el, for @code{'last'}).
  
  @item @code{q}@code{ThreadExtraInfo}@code{,}@var{id} --- extra thread info
  
--- 20863,20872 ----
  @end table
  
  In response to each query, the target will reply with a list of one or
! more thread ids, in big-endian unsigned hex, separated by commas.
! @value{GDBN} will respond to each reply with a request for more thread
! ids (using the @code{qs} form of the query), until the target responds
! with @code{l} (lower-case el, for @code{'last'}).
  
  @item @code{q}@code{ThreadExtraInfo}@code{,}@var{id} --- extra thread info
  



  reply	other threads:[~2004-12-07 20:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-27 22:56 Jim Blandy
2004-12-03  0:31 ` Jim Blandy
2004-12-03 21:54   ` Michael Snyder
2004-12-03 22:37     ` Daniel Jacobowitz
2004-12-07 20:26       ` Jim Blandy [this message]
2004-12-07 21:44         ` Eli Zaretskii
2004-12-08  6:05           ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt23byh507t.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox