From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18283 invoked by alias); 7 Dec 2004 20:21:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18175 invoked from network); 7 Dec 2004 20:21:42 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 7 Dec 2004 20:21:42 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iB7KLbao004840 for ; Tue, 7 Dec 2004 15:21:42 -0500 Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iB7KLZr05011; Tue, 7 Dec 2004 15:21:36 -0500 To: Daniel Jacobowitz Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: RFA: remote.c: parse thread ID's as unsigned values References: <41B0DF1C.2080800@redhat.com> <20041203223050.GA15548@nevyn.them.org> From: Jim Blandy Date: Tue, 07 Dec 2004 20:26:00 -0000 In-Reply-To: <20041203223050.GA15548@nevyn.them.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-12/txt/msg00211.txt.bz2 Daniel Jacobowitz writes: > On Fri, Dec 03, 2004 at 01:48:12PM -0800, Michael Snyder wrote: > > Jim Blandy wrote: > > >One month ping. > > > > Well heck, I'm not the remote.c maintainer, but I'm the thread > > maintainer (or one of them). > > > > Your change certainly seems reasonable to me. Can't think why > > we would want thread ids to be sign extended... > > > > Under the assumption that you've run into a situation where this > > is applicable, and the change tests out well, I'll give it the nod. > > Fine by me too - but if the manual is unclear, Jim, could you clarify > it? I've committed the patch, thanks. How's this for the documentation change? 2004-12-07 Jim Blandy * gdb.texinfo (General Query Packets): Specify that thread ID's in the 'qC' and 'qThreadInfo' packets are unsigned hexidecimal numbers. Index: gdb/doc/gdb.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v retrieving revision 1.228 diff -c -p -r1.228 gdb.texinfo *** gdb/doc/gdb.texinfo 7 Dec 2004 11:06:04 -0000 1.228 --- gdb/doc/gdb.texinfo 7 Dec 2004 20:14:33 -0000 *************** Return the current thread id. *** 20834,20840 **** Reply: @table @samp @item @code{QC}@var{pid} ! Where @var{pid} is a HEX encoded 16 bit process id. @item * Any other reply implies the old pid. @end table --- 20834,20840 ---- Reply: @table @samp @item @code{QC}@var{pid} ! Where @var{pid} is an unsigned hexidecimal process id. @item * Any other reply implies the old pid. @end table *************** a comma-separated list of thread ids *** 20863,20872 **** @end table In response to each query, the target will reply with a list of one or ! more thread ids, in big-endian hex, separated by commas. @value{GDBN} ! will respond to each reply with a request for more thread ids (using the ! @code{qs} form of the query), until the target responds with @code{l} ! (lower-case el, for @code{'last'}). @item @code{q}@code{ThreadExtraInfo}@code{,}@var{id} --- extra thread info --- 20863,20872 ---- @end table In response to each query, the target will reply with a list of one or ! more thread ids, in big-endian unsigned hex, separated by commas. ! @value{GDBN} will respond to each reply with a request for more thread ! ids (using the @code{qs} form of the query), until the target responds ! with @code{l} (lower-case el, for @code{'last'}). @item @code{q}@code{ThreadExtraInfo}@code{,}@var{id} --- extra thread info