RFA: remote.c: parse thread ID's as unsigned values

[Jim Blandy <jimb@redhat.com>]

The GDB manual isn't clear on whether thread ID's carried in the
responses to the qfThreadInfo and the qC packet may have a sign; I'm
assuming that they're just a series of hex digits.

2004-10-27  Jim Blandy  <jimb@redhat.com>

	* remote.c (remote_threads_info, remote_current_thread): Use
	strtoul to parse thread ID numbers.

Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.134
diff -c -r1.134 remote.c
*** gdb/remote.c	26 Apr 2004 09:02:41 -0000	1.134
--- gdb/remote.c	27 Oct 2004 21:26:40 -0000
***************
*** 1755,1761 ****
    putpkt ("qC");
    getpkt (buf, (rs->remote_packet_size), 0);
    if (buf[0] == 'Q' && buf[1] == 'C')
!     return pid_to_ptid (strtol (&buf[2], NULL, 16));
    else
      return oldpid;
  }
--- 1755,1766 ----
    putpkt ("qC");
    getpkt (buf, (rs->remote_packet_size), 0);
    if (buf[0] == 'Q' && buf[1] == 'C')
!     /* Use strtoul here, so we'll correctly parse values whose highest
!        bit is set.  The protocol carries them as a simple series of
!        hex digits; in the absence of a sign, strtol will see such
!        values as positive numbers out of range for signed 'long', and
!        return LONG_MAX to indicate an overflow.  */
!     return pid_to_ptid (strtoul (&buf[2], NULL, 16));
    else
      return oldpid;
  }
***************
*** 1802,1808 ****
  	    {
  	      do
  		{
! 		  tid = strtol (bufp, &bufp, 16);
  		  if (tid != 0 && !in_thread_list (pid_to_ptid (tid)))
  		    add_thread (pid_to_ptid (tid));
  		}
--- 1807,1819 ----
  	    {
  	      do
  		{
! 		  /* Use strtoul here, so we'll correctly parse values
! 		     whose highest bit is set.  The protocol carries
! 		     them as a simple series of hex digits; in the
! 		     absence of a sign, strtol will see such values as
! 		     positive numbers out of range for signed 'long',
! 		     and return LONG_MAX to indicate an overflow.  */
! 		  tid = strtoul (bufp, &bufp, 16);
  		  if (tid != 0 && !in_thread_list (pid_to_ptid (tid)))
  		    add_thread (pid_to_ptid (tid));
  		}