From: Eli Zaretskii <eliz@gnu.org>
To: Jason Kraftcheck <kraftche@cae.wisc.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: fix list/edit command in hook-stop
Date: Tue, 28 Feb 2006 22:33:00 -0000 [thread overview]
Message-ID: <uzmkbp7p2.fsf@gnu.org> (raw)
In-Reply-To: <44047AAB.4070102@cae.wisc.edu> (message from Jason Kraftcheck on Tue, 28 Feb 2006 10:30:35 -0600)
> Date: Tue, 28 Feb 2006 10:30:35 -0600
> From: Jason Kraftcheck <kraftche@cae.wisc.edu>
> CC: Eli Zaretskii <eliz@gnu.org>
>
> Eli Zaretskii wrote:
> ...
> >
> > I'd suggest a comment here explaining why set_current_sal_from_frame
> > is called.
>
> OK.
> [...]
> + /* Set current sal for use by edit or list commands if
> + called from within hook-stop */
> + if (target_has_stack)
> + set_current_sal_from_frame (get_current_frame (), 1);
> + catch_errors (hook_stop_stub, stop_command,
> + "Error while running hook_stop:\n", RETURN_MASK_ALL);
> + }
Thanks. However, I thought we should explain why
set_current_sal_from_frame is called here. I believe the reason is
that without the call, the current sal will not be up to date if
`edit' or `list' are called inside a hook-stop.
next prev parent reply other threads:[~2006-02-28 20:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-23 18:21 Jason Kraftcheck
2006-02-23 21:13 ` Daniel Jacobowitz
2006-02-23 22:52 ` Jason Kraftcheck
2006-02-24 7:53 ` Eli Zaretskii
2006-02-28 18:49 ` Jason Kraftcheck
2006-02-28 22:33 ` Eli Zaretskii [this message]
2006-03-01 17:58 ` Daniel Jacobowitz
2006-03-01 19:19 ` Eli Zaretskii
2006-03-30 16:48 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uzmkbp7p2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kraftche@cae.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox