From: Jason Kraftcheck <kraftche@cae.wisc.edu>
To: gdb-patches@sources.redhat.com
Subject: fix list/edit command in hook-stop
Date: Thu, 23 Feb 2006 18:21:00 -0000 [thread overview]
Message-ID: <43FDFCDE.9090603@cae.wisc.edu> (raw)
An 'edit' or 'list' command in hook-stop doesn't work because the
current sal isn't updated until after hook-stop is run. The following
trivial change moves the invocation of hook-stop later in normal_stop.
This won't fix the problem in all cases, as the sal is apparently only
updated if print_stack_frame is called. But it doesn't hurt anything
and works more often than without the change.
2006-02-23 Jason Kraftcheck <kraftche@cae.wisc.edu>
* infrun.c (normal_stop): call hook-stop handler later, after
current sal has been set.
diff -upr gdb-6.4/gdb/infrun.c mod/gdb/infrun.c
--- gdb-6.4/gdb/infrun.c 2005-11-14 09:35:16.000000000 -0600
+++ mod/gdb/infrun.c 2006-02-23 11:55:12.469293121 -0600
@@ -3038,12 +3038,6 @@ Further execution is probably impossible
target_terminal_ours ();
- /* Look up the hook_stop and run it (CLI internally handles problem
- of stop_command's pre-hook not existing). */
- if (stop_command)
- catch_errors (hook_stop_stub, stop_command,
- "Error while running hook_stop:\n", RETURN_MASK_ALL);
-
if (!target_has_stack)
{
@@ -3140,6 +3134,12 @@ Further execution is probably impossible
select_frame (get_current_frame ());
}
+ /* Look up the hook_stop and run it (CLI internally handles problem
+ of stop_command's pre-hook not existing). */
+ if (stop_command)
+ catch_errors (hook_stop_stub, stop_command,
+ "Error while running hook_stop:\n", RETURN_MASK_ALL);
+
done:
annotate_stopped ();
observer_notify_normal_stop (stop_bpstat);
next reply other threads:[~2006-02-23 18:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-23 18:21 Jason Kraftcheck [this message]
2006-02-23 21:13 ` Daniel Jacobowitz
2006-02-23 22:52 ` Jason Kraftcheck
2006-02-24 7:53 ` Eli Zaretskii
2006-02-28 18:49 ` Jason Kraftcheck
2006-02-28 22:33 ` Eli Zaretskii
2006-03-01 17:58 ` Daniel Jacobowitz
2006-03-01 19:19 ` Eli Zaretskii
2006-03-30 16:48 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43FDFCDE.9090603@cae.wisc.edu \
--to=kraftche@cae.wisc.edu \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox