Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jason Kraftcheck <kraftche@cae.wisc.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: fix list/edit command in hook-stop
Date: Thu, 23 Feb 2006 21:13:00 -0000	[thread overview]
Message-ID: <20060223210220.GC2353@nevyn.them.org> (raw)
In-Reply-To: <43FDFCDE.9090603@cae.wisc.edu>

On Thu, Feb 23, 2006 at 12:20:14PM -0600, Jason Kraftcheck wrote:
> An 'edit' or 'list' command in hook-stop doesn't work because the
> current sal isn't updated until after hook-stop is run.  The following
> trivial change moves the invocation of hook-stop later in normal_stop.
> This won't fix the problem in all cases, as the sal is apparently only
> updated if print_stack_frame is called.  But it doesn't hurt anything
> and works more often than without the change.
> 
> 
> 2006-02-23  Jason Kraftcheck  <kraftche@cae.wisc.edu>
> 
> 	* infrun.c (normal_stop): call hook-stop handler later, after
> 	  current sal has been set.

From the manual:

   In addition, a pseudo-command, `stop' exists.  Defining
(`hook-stop') makes the associated commands execute every time
execution stops in your program: before breakpoint commands are run,
displays are printed, or the stack frame is printed.

Your patch would change that; a stop hook which conditionally continued
would now be noisy instead of silent, so I don't think this is a good
change.

Can you just update the sal explicitly, instead of moving things around?


-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-02-23 21:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-23 18:21 Jason Kraftcheck
2006-02-23 21:13 ` Daniel Jacobowitz [this message]
2006-02-23 22:52   ` Jason Kraftcheck
2006-02-24  7:53     ` Eli Zaretskii
2006-02-28 18:49       ` Jason Kraftcheck
2006-02-28 22:33         ` Eli Zaretskii
2006-03-01 17:58           ` Daniel Jacobowitz
2006-03-01 19:19             ` Eli Zaretskii
2006-03-30 16:48             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060223210220.GC2353@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kraftche@cae.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox