From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] Add support for catch Ada exceptions (take 2)
Date: Sun, 31 Dec 2006 21:59:00 -0000 [thread overview]
Message-ID: <uwt47afr4.fsf@gnu.org> (raw)
In-Reply-To: <20061231060649.GF25236@adacore.com> (message from Joel Brobecker on Sun, 31 Dec 2006 10:06:49 +0400)
> Date: Sun, 31 Dec 2006 10:06:49 +0400
> From: Joel Brobecker <brobecker@adacore.com>
>
> + switch (b->type)
> + {
> + case bp_catch_exception:
> + if (b->addr_string != NULL)
> + {
> + const char *template = _("`%s' Ada exception");
> + char *msg = alloca (strlen (template) + strlen (b->addr_string));
> +
> + sprintf (msg, _("`%s' Ada exception"), b->addr_string);
Why don't you use `template' instead of having two identical strings?
next prev parent reply other threads:[~2006-12-31 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 6:06 Joel Brobecker
2006-12-31 21:59 ` Eli Zaretskii [this message]
2006-12-31 22:11 ` Mark Kettenis
2007-01-02 5:44 ` Joel Brobecker
2007-01-02 13:27 ` Andreas Schwab
2007-01-02 14:34 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uwt47afr4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox