Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] Add support for catch Ada exceptions (take 2)
Date: Tue, 02 Jan 2007 13:27:00 -0000	[thread overview]
Message-ID: <je1wmdimp2.fsf@sykes.suse.de> (raw)
In-Reply-To: <20070102054523.GF17211@adacore.com> (Joel Brobecker's message of 	"Tue, 2 Jan 2007 09:45:23 +0400")

Joel Brobecker <brobecker@adacore.com> writes:

>> > +  switch (b->type)
>> > +    {
>> > +      case bp_catch_exception:
>> > +        if (b->addr_string != NULL)
>> > +          {
>> > +            const char *template = _("`%s' Ada exception");
>> > +            char *msg = alloca (strlen (template) + strlen (b->addr_string));
>> > +            
>> > +            sprintf (msg, _("`%s' Ada exception"), b->addr_string);
>> 
>> Why don't you use `template' instead of having two identical strings?
>
> That's what I first did, but the compiler complains that he cannot check
> the string format.

If you use static const char[] instead then the compiler is able to do the
checks.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


  reply	other threads:[~2007-01-02 13:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-31  6:06 Joel Brobecker
2006-12-31 21:59 ` Eli Zaretskii
2006-12-31 22:11   ` Mark Kettenis
2007-01-02  5:44   ` Joel Brobecker
2007-01-02 13:27     ` Andreas Schwab [this message]
2007-01-02 14:34     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=je1wmdimp2.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox