From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-46899-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22848 invoked by alias); 2 Jan 2007 13:27:03 -0000
Received: (qmail 22837 invoked by uid 22791); 2 Jan 2007 13:27:02 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.suse.de (HELO mx1.suse.de) (195.135.220.2)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 Jan 2007 13:26:56 +0000
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx1.suse.de (Postfix) with ESMTP id CBC0F12292; 	Tue,  2 Jan 2007 14:26:53 +0100 (CET)
From: Andreas Schwab <schwab@suse.de>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] Add support for catch Ada exceptions (take 2)
References: <20061231060649.GF25236@adacore.com> <uwt47afr4.fsf@gnu.org> 	<20070102054523.GF17211@adacore.com>
X-Yow: I just bought FLATBUSH from MICKEY MANTLE!
Date: Tue, 02 Jan 2007 13:27:00 -0000
In-Reply-To: <20070102054523.GF17211@adacore.com> (Joel Brobecker's message of 	"Tue, 2 Jan 2007 09:45:23 +0400")
Message-ID: <je1wmdimp2.fsf@sykes.suse.de>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-01/txt/msg00048.txt.bz2

Joel Brobecker <brobecker@adacore.com> writes:

>> > +  switch (b->type)
>> > +    {
>> > +      case bp_catch_exception:
>> > +        if (b->addr_string != NULL)
>> > +          {
>> > +            const char *template = _("`%s' Ada exception");
>> > +            char *msg = alloca (strlen (template) + strlen (b->addr_string));
>> > +            
>> > +            sprintf (msg, _("`%s' Ada exception"), b->addr_string);
>> 
>> Why don't you use `template' instead of having two identical strings?
>
> That's what I first did, but the compiler complains that he cannot check
> the string format.

If you use static const char[] instead then the compiler is able to do the
checks.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."