From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-46844-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2277 invoked by alias); 31 Dec 2006 21:59:41 -0000
Received: (qmail 2268 invoked by uid 22791); 31 Dec 2006 21:59:41 -0000
X-Spam-Check-By: sourceware.org
Received: from heller.inter.net.il (HELO heller.inter.net.il) (192.114.186.73)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 31 Dec 2006 21:59:36 +0000
Received: from HOME-C4E4A596F7 (IGLD-84-229-218-43.inter.net.il [84.229.218.43]) 	by heller.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id BKJ40590 (AUTH halo1); 	Sun, 31 Dec 2006 23:59:25 +0200 (IST)
Date: Sun, 31 Dec 2006 21:59:00 -0000
Message-Id: <uwt47afr4.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
CC: gdb-patches@sourceware.org
In-reply-to: <20061231060649.GF25236@adacore.com> (message from Joel Brobecker 	on Sun, 31 Dec 2006 10:06:49 +0400)
Subject: Re: [RFC/RFA] Add support for catch Ada exceptions (take 2)
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <20061231060649.GF25236@adacore.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-12/txt/msg00425.txt.bz2

> Date: Sun, 31 Dec 2006 10:06:49 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> +  switch (b->type)
> +    {
> +      case bp_catch_exception:
> +        if (b->addr_string != NULL)
> +          {
> +            const char *template = _("`%s' Ada exception");
> +            char *msg = alloca (strlen (template) + strlen (b->addr_string));
> +            
> +            sprintf (msg, _("`%s' Ada exception"), b->addr_string);

Why don't you use `template' instead of having two identical strings?