Re: [RFA/doco] Document task-specific breakpoints

[Eli Zaretskii <eliz@gnu.org>]

> Date: Wed, 25 Mar 2009 15:02:36 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> As promised when I sent the code patches for task-specific breakpoints,
> here is the associated documentation.

Thanks.

> 2009-03-25  Joel Brobecker  <brobecker@adacore.com>
> 
>         * gdb.texinfo (Ada Tasks): Add documentation about task-specific
>         breakpoints.
> 
> OK to commit?

Yes, with a few comments:

> +@cindex breakpoints and tasks

Suggest to mention Ada explicitly:

  @cindex breakpoints and tasks, in Ada

> +@cindex task breakpoints

Likewise.

> +@kindex break @dots{} task @var{taskno}

Similarly:

  @kindex break @dots{} task @var{taskno}@r{ (Ada)}

> +@var{linespec} specifies source lines, as described
> +in @ref{Set Breaks,,Setting breakpoints}.

It is better to point to "Specify Location", where @var{linespec} is
_really_ described.

> +Breakpoint 5, test_task_debug.tB.1 (_task=0x11ffffc60)
                                ^^^^^
What is this part?  Should we explain it in some footnote?  And what
about _task=0x11ffffc60 part, should it perhaps be explained, too?

> +(@value{GDBP}) info tasks
> +  ID       TID P-ID Pri State                 Name
> +   1 140022020   0   15 Child Activation Wait main_task
> +*  2 140045060   1   15 Running               t2

"Running"? shouldn't it be stopped at breakpoint?

Finally, please add a cross-reference to here in the "Set Breaks"
node, saying that Ada supports thread-specific breakpoints.

Thanks.