From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62479-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17186 invoked by alias); 26 Mar 2009 04:25:57 -0000
Received: (qmail 17142 invoked by uid 22791); 26 Mar 2009 04:25:56 -0000
X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 	tests=AWL,BAYES_00,J_CHICKENPOX_37,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Mar 2009 04:25:49 +0000
Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KH300000IUPP800@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Thu, 26 Mar 2009 06:25:01 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.127.23.114]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KH300EBPIXP3HB0@i-mtaout7.012.net.il>; Thu, 26 Mar 2009 06:25:01 +0200 (IST)
Date: Thu, 26 Mar 2009 13:10:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA/doco] Document task-specific breakpoints
In-reply-to: <20090325220236.GF9472@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uwsacnc65.fsf@gnu.org>
References: <20090325214556.GD9472@adacore.com> <20090325220236.GF9472@adacore.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-03/txt/msg00589.txt.bz2

> Date: Wed, 25 Mar 2009 15:02:36 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> As promised when I sent the code patches for task-specific breakpoints,
> here is the associated documentation.

Thanks.

> 2009-03-25  Joel Brobecker  <brobecker@adacore.com>
> 
>         * gdb.texinfo (Ada Tasks): Add documentation about task-specific
>         breakpoints.
> 
> OK to commit?

Yes, with a few comments:

> +@cindex breakpoints and tasks

Suggest to mention Ada explicitly:

  @cindex breakpoints and tasks, in Ada

> +@cindex task breakpoints

Likewise.

> +@kindex break @dots{} task @var{taskno}

Similarly:

  @kindex break @dots{} task @var{taskno}@r{ (Ada)}

> +@var{linespec} specifies source lines, as described
> +in @ref{Set Breaks,,Setting breakpoints}.

It is better to point to "Specify Location", where @var{linespec} is
_really_ described.

> +Breakpoint 5, test_task_debug.tB.1 (_task=0x11ffffc60)
                                ^^^^^
What is this part?  Should we explain it in some footnote?  And what
about _task=0x11ffffc60 part, should it perhaps be explained, too?

> +(@value{GDBP}) info tasks
> +  ID       TID P-ID Pri State                 Name
> +   1 140022020   0   15 Child Activation Wait main_task
> +*  2 140045060   1   15 Running               t2

"Running"? shouldn't it be stopped at breakpoint?

Finally, please add a cross-reference to here in the "Set Breaks"
node, saying that Ada supports thread-specific breakpoints.

Thanks.