Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Hilfinger <hilfingr@gnat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Internationalize Ada files
Date: Sun, 08 Jan 2006 19:32:00 -0000	[thread overview]
Message-ID: <uu0cesegg.fsf@gnu.org> (raw)
In-Reply-To: <20060108072209.33B0048CDEE@nile.gnat.com> (message from Paul 	Hilfinger on Sun, 8 Jan 2006 02:22:09 -0500 (EST))

> From: Paul Hilfinger <hilfingr@gnat.com>
> Date: Sun,  8 Jan 2006 02:22:09 -0500 (EST)
> 
> I have committed the following trivial change to the Ada files.

Thanks.  However, i18n changes are never trivial, IMHO.

>  yyerror (char *msg)
>  {
> -  error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr);
> +  error (_("A %s in expression, near `%s'."), (msg ? msg : _("error")), lexptr);
>  }

I agree with Andreas here: it would be very hard to translate this
message correctly.  Perhaps this message should have been rewritten as
2 different messages: one when msg is NULL, the other when it isn't.

> -          error (_("Attempt to index or call something other than an \
> -array or function"));
> +          error (_("Attempt to index or call something other than an "
> +		   "array or function"));

Does xgettext support strings broken between 2 lines?

>            ada_to_fixed_value (unwrap_value
>                                (ada_value_struct_elt
> -                               (arg1, &exp->elts[pc + 2].string, "record")));
> +                               (arg1, &exp->elts[pc + 2].string, _("record"))));

Do we really want to translate the "record" part here?  Could you
please tell what would the string produced by this call to
ada_to_fixed_value look like in English?


  parent reply	other threads:[~2006-01-08 19:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-08  7:22 Paul Hilfinger
2006-01-08 11:12 ` Andreas Schwab
2006-01-08 19:32 ` Eli Zaretskii [this message]
2006-01-09 10:12   ` Paul Hilfinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uu0cesegg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=hilfingr@gnat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox