From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26860 invoked by alias); 8 Jan 2006 19:32:42 -0000 Received: (qmail 26842 invoked by uid 22791); 8 Jan 2006 19:32:41 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 08 Jan 2006 19:32:40 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-237-132.inter.net.il [84.228.237.132]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id DII27117 (AUTH halo1); Sun, 8 Jan 2006 21:32:32 +0200 (IST) Date: Sun, 08 Jan 2006 19:32:00 -0000 Message-Id: From: Eli Zaretskii To: Paul Hilfinger CC: gdb-patches@sourceware.org In-reply-to: <20060108072209.33B0048CDEE@nile.gnat.com> (message from Paul Hilfinger on Sun, 8 Jan 2006 02:22:09 -0500 (EST)) Subject: Re: [commit] Internationalize Ada files Reply-to: Eli Zaretskii References: <20060108072209.33B0048CDEE@nile.gnat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00087.txt.bz2 > From: Paul Hilfinger > Date: Sun, 8 Jan 2006 02:22:09 -0500 (EST) > > I have committed the following trivial change to the Ada files. Thanks. However, i18n changes are never trivial, IMHO. > yyerror (char *msg) > { > - error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr); > + error (_("A %s in expression, near `%s'."), (msg ? msg : _("error")), lexptr); > } I agree with Andreas here: it would be very hard to translate this message correctly. Perhaps this message should have been rewritten as 2 different messages: one when msg is NULL, the other when it isn't. > - error (_("Attempt to index or call something other than an \ > -array or function")); > + error (_("Attempt to index or call something other than an " > + "array or function")); Does xgettext support strings broken between 2 lines? > ada_to_fixed_value (unwrap_value > (ada_value_struct_elt > - (arg1, &exp->elts[pc + 2].string, "record"))); > + (arg1, &exp->elts[pc + 2].string, _("record")))); Do we really want to translate the "record" part here? Could you please tell what would the string produced by this call to ada_to_fixed_value look like in English?