From: Eli Zaretskii <eliz@gnu.org>
To: teawater <teawater@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Process record and replay, 4/10
Date: Fri, 14 Nov 2008 15:56:00 -0000 [thread overview]
Message-ID: <uprkyo7la.fsf@gnu.org> (raw)
In-Reply-To: <daef60380811102134k3b518740vd3edefc1f41a3715@mail.gmail.com>
> Date: Tue, 11 Nov 2008 13:34:10 +0800
> From: teawater <teawater@gmail.com>
> Cc: gdb-patches@sourceware.org
>
> >> >> + /* Set the real beneath function pointers. */
> >> >
> >> > Could you please rephrase this comment? I don't understand what it
> >> > tries to say.
> >> >
> >> > Thanks.
> >> >
> >>
> >> What about change it to "Update the function pointers that process record use."
> >
> > Maybe, but you use the word "beneath" in many more places, and also in
> > symbol names, so that word should probably not be removed from the
> > comment.
>
> I use "beneath" because:
> struct target_ops
> {
> struct target_ops *beneath; /* To the target under this one. */
>
Then how about "Set pointers to functions in the target beneath us."?
next prev parent reply other threads:[~2008-11-14 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 7:48 teawater
2008-11-07 15:12 ` Eli Zaretskii
2008-11-08 6:29 ` teawater
2008-11-08 9:28 ` Eli Zaretskii
2008-11-11 5:50 ` teawater
2008-11-13 15:09 ` teawater
2008-11-14 0:27 ` Eli Zaretskii
2008-11-14 15:06 ` teawater
2008-11-14 15:56 ` Eli Zaretskii [this message]
2008-11-14 16:29 ` teawater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uprkyo7la.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox