From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59941-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2432 invoked by alias); 14 Nov 2008 11:46:18 -0000
Received: (qmail 2368 invoked by uid 22791); 14 Nov 2008 11:46:16 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Nov 2008 11:45:34 +0000
Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KAB00400N2WBQ00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Fri, 14 Nov 2008 13:46:11 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.205.49]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KAB00DOYNCX5T60@i-mtaout1.012.net.il>; Fri, 14 Nov 2008 13:46:11 +0200 (IST)
Date: Fri, 14 Nov 2008 15:56:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Process record and replay, 4/10
In-reply-to: <daef60380811102134k3b518740vd3edefc1f41a3715@mail.gmail.com>
X-012-Sender: halo1@inter.net.il
To: teawater <teawater@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uprkyo7la.fsf@gnu.org>
References: <daef60380811052347y4077eb2ehfb890faf45c6e87b@mail.gmail.com> <uod0rshae.fsf@gnu.org> <daef60380811072228i4c180776qffbf933fba381c17@mail.gmail.com> <u7i7esh2a.fsf@gnu.org> <daef60380811102134k3b518740vd3edefc1f41a3715@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00332.txt.bz2

> Date: Tue, 11 Nov 2008 13:34:10 +0800
> From: teawater <teawater@gmail.com>
> Cc: gdb-patches@sourceware.org
> 
> >> >> +      /* Set the real beneath function pointers. */
> >> >
> >> > Could you please rephrase this comment?  I don't understand what it
> >> > tries to say.
> >> >
> >> > Thanks.
> >> >
> >>
> >> What about change it to "Update the function pointers that process record use."
> >
> > Maybe, but you use the word "beneath" in many more places, and also in
> > symbol names, so that word should probably not be removed from the
> > comment.
> 
> I use "beneath" because:
> struct target_ops
>   {
>     struct target_ops *beneath;	/* To the target under this one.  */
> 

Then how about "Set pointers to functions in the target beneath us."?