Re: [RFA] Process record and replay, 4/10

[teawater <teawater@gmail.com>]

On Fri, Nov 14, 2008 at 19:44, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Tue, 11 Nov 2008 13:34:10 +0800
>> From: teawater <teawater@gmail.com>
>> Cc: gdb-patches@sourceware.org
>>
>> >> >> +      /* Set the real beneath function pointers. */
>> >> >
>> >> > Could you please rephrase this comment?  I don't understand what it
>> >> > tries to say.
>> >> >
>> >> > Thanks.
>> >> >
>> >>
>> >> What about change it to "Update the function pointers that process record use."
>> >
>> > Maybe, but you use the word "beneath" in many more places, and also in
>> > symbol names, so that word should probably not be removed from the
>> > comment.
>>
>> I use "beneath" because:
>> struct target_ops
>>   {
>>     struct target_ops *beneath;       /* To the target under this one.  */
>>
>
> Then how about "Set pointers to functions in the target beneath us."?
>

Great! I will use it. :)