From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59946-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15757 invoked by alias); 14 Nov 2008 13:51:57 -0000
Received: (qmail 15645 invoked by uid 22791); 14 Nov 2008 13:51:57 -0000
X-Spam-Check-By: sourceware.org
Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.187)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Nov 2008 13:51:20 +0000
Received: by ti-out-0910.google.com with SMTP id d10so1117924tib.12         for <gdb-patches@sourceware.org>; Fri, 14 Nov 2008 05:51:17 -0800 (PST)
Received: by 10.110.15.9 with SMTP id 9mr1152457tio.27.1226670677358;         Fri, 14 Nov 2008 05:51:17 -0800 (PST)
Received: by 10.110.103.3 with HTTP; Fri, 14 Nov 2008 05:51:17 -0800 (PST)
Message-ID: <daef60380811140551l476de9e9o45a219518ad63d1b@mail.gmail.com>
Date: Fri, 14 Nov 2008 16:29:00 -0000
From: teawater <teawater@gmail.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Subject: Re: [RFA] Process record and replay, 4/10
Cc: gdb-patches@sourceware.org
In-Reply-To: <uprkyo7la.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <daef60380811052347y4077eb2ehfb890faf45c6e87b@mail.gmail.com> 	 <uod0rshae.fsf@gnu.org> 	 <daef60380811072228i4c180776qffbf933fba381c17@mail.gmail.com> 	 <u7i7esh2a.fsf@gnu.org> 	 <daef60380811102134k3b518740vd3edefc1f41a3715@mail.gmail.com> 	 <uprkyo7la.fsf@gnu.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00337.txt.bz2

On Fri, Nov 14, 2008 at 19:44, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Tue, 11 Nov 2008 13:34:10 +0800
>> From: teawater <teawater@gmail.com>
>> Cc: gdb-patches@sourceware.org
>>
>> >> >> +      /* Set the real beneath function pointers. */
>> >> >
>> >> > Could you please rephrase this comment?  I don't understand what it
>> >> > tries to say.
>> >> >
>> >> > Thanks.
>> >> >
>> >>
>> >> What about change it to "Update the function pointers that process record use."
>> >
>> > Maybe, but you use the word "beneath" in many more places, and also in
>> > symbol names, so that word should probably not be removed from the
>> > comment.
>>
>> I use "beneath" because:
>> struct target_ops
>>   {
>>     struct target_ops *beneath;       /* To the target under this one.  */
>>
>
> Then how about "Set pointers to functions in the target beneath us."?
>

Great! I will use it. :)