From: Eli Zaretskii <eliz@gnu.org>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Use i386_use_watchpoints for go32v2, bds and windows native
Date: Mon, 09 Feb 2009 04:10:00 -0000 [thread overview]
Message-ID: <uprhss12h.fsf@gnu.org> (raw)
In-Reply-To: <000001c98a44$29b02a30$7d107e90$@u-strasbg.fr>
> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Date: Mon, 9 Feb 2009 00:22:50 +0100
>
> The correction of this problem is easy, as it is already implemented
> for linux.
> The patch only adds
> #define I386_WATCHPOINTS_IN_TARGET_VECTOR
> to all config/i386/nm-*.h
> that defines I386_USE_GENERIC_WATCHPOINTS
> before including nm-i386.h
> and add the corresponding call
> to i386_use_watchpoints (target)
> in the native file when the target vector gets
> defined.
>
> I found only three places where this happens:
> nm-go32.h with native go32-nat.c
> nm-fbsd.h with native i386bsd-nat.c
> and
> nm-cygwin.h and nm-cygwin64.h with native windows-nat.c
I don't necessarily object, but could you please explain what does
each of these two changes do? That is, what does defining
I386_WATCHPOINTS_IN_TARGET_VECTOR accomplish, and why we need to call
i386_use_watchpoints?
Thanks.
next prev parent reply other threads:[~2009-02-09 4:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 23:22 Pierre Muller
2009-02-09 4:10 ` Eli Zaretskii [this message]
2009-02-09 7:33 ` Pierre Muller
2009-02-09 20:38 ` Eli Zaretskii
2009-02-13 11:06 ` [RFA-v2] " Pierre Muller
2009-02-14 19:22 ` Christopher Faylor
2009-02-20 10:56 ` [PING][RFA-v2] " Pierre Muller
2009-02-21 0:04 ` Mark Kettenis
2009-02-21 10:55 ` Pierre Muller
2009-02-09 11:07 ` [RFA] " Mark Kettenis
2009-02-09 12:34 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uprhss12h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox