From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61580-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15158 invoked by alias); 9 Feb 2009 04:10:16 -0000
Received: (qmail 15149 invoked by uid 22791); 9 Feb 2009 04:10:15 -0000
X-SWARE-Spam-Status: No, hits=1.5 required=5.0 	tests=AWL,BAYES_00,BOTNET,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Feb 2009 04:10:11 +0000
Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KES00B0062B4Y00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Mon, 09 Feb 2009 06:10:20 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.128.7]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KES00HJX697S3C0@i-mtaout1.012.net.il>; Mon, 09 Feb 2009 06:10:20 +0200 (IST)
Date: Mon, 09 Feb 2009 04:10:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Use i386_use_watchpoints for go32v2, bds and windows native
In-reply-to: <000001c98a44$29b02a30$7d107e90$@u-strasbg.fr>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uprhss12h.fsf@gnu.org>
References: <000001c98a44$29b02a30$7d107e90$@u-strasbg.fr>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-02/txt/msg00199.txt.bz2

> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Date: Mon, 9 Feb 2009 00:22:50 +0100
> 
>   The correction of this problem is easy, as it is already implemented
> for linux.
>   The patch only adds
> #define I386_WATCHPOINTS_IN_TARGET_VECTOR
> to all config/i386/nm-*.h
> that defines I386_USE_GENERIC_WATCHPOINTS 
> before including nm-i386.h
> and add the corresponding call
> to i386_use_watchpoints (target)
> in the native file when the target vector gets   
> defined.
> 
>   I found only three places where this happens:
> nm-go32.h with native go32-nat.c
> nm-fbsd.h with native i386bsd-nat.c
> and 
> nm-cygwin.h and nm-cygwin64.h with native windows-nat.c

I don't necessarily object, but could you please explain what does
each of these two changes do?  That is, what does defining
I386_WATCHPOINTS_IN_TARGET_VECTOR accomplish, and why we need to call
i386_use_watchpoints?

Thanks.