Re: [RFA] Use i386_use_watchpoints for go32v2, bds and windows native

Eli Zaretskii
2009-02-09T04:10:16Z

> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Date: Mon, 9 Feb 2009 00:22:50 +0100
>
> The correction of this problem is easy, as it is already implemented
> for linux.
> The patch only adds
> #define I386_WATCHPOINTS_IN_TARGET_VECTOR
> to all config/i386/nm-*.h
> that defines I386_USE_GENERIC_WATCHPOINTS
> before including nm-i386.h
> and add the corresponding call
> to i386_use_watchpoints (target)
> in the native file when the target vector gets
> defined.
>
> I found only three places where this happens:
> nm-go32.h with native go32-nat.c
> nm-fbsd.h with native i386bsd-nat.c
> and
> nm-cygwin.h and nm-cygwin64.h with native windows-nat.c

I don't necessarily object, but could you please explain what does
each of these two changes do? That is, what does defining
I386_WATCHPOINTS_IN_TARGET_VECTOR accomplish, and why we need to call
i386_use_watchpoints?

Thanks.