RE: [RFA] Use i386_use_watchpoints for go32v2, bds and windows native

Pierre Muller
2009-02-09T12:34:26Z

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Mark Kettenis
> Envoyé : Monday, February 09, 2009 12:07 PM
> À : muller@ics.u-strasbg.fr
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] Use i386_use_watchpoints for go32v2, bds and windows
> native
>
> > From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> > Date: Mon, 9 Feb 2009 00:22:50 +0100
> >
> > ChangeLog entry:
> >
> > 2009-02-08 Pierre Muller <muller@ics.u-strasbg.fr>
> >
> > * Extend use of i386_use_watchpoints to all i386 native files
> > using hardware watchpoints.
> > go32-nat.c (init_go32_ops): Call i386_use_watchpoints.
> > i386bsd-nat.c (i386bsd_target): Ditto.
> > windows-nat.c (init_windows_ops): Ditto.
> > config/i386/nm-cygwin.h: Define
> I386_WATCHPOINTS_IN_TARGET_VECTOR.
> > config/i386/nm-cygwin64.h: Ditto.
> > config/i386/nm-fbsd.h: Ditto.
> > config/i386/nm-go32.h: Ditto.
>
> Only FreeBSD has hardware watchpoint support, so your change to
> i386bsd-nat.c isn't quite right.

I didn't manage to figure that out, thanks.

This means that I should move the i386bsd-nat.c change
to i386fbsd-nat.c source file.
Would the part below be OK then?

Pierre Muller
Pascal language support maintainer for GDB

Index: gdb/i386fbsd-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/i386fbsd-nat.c,v
retrieving revision 1.16
diff -u -p -r1.16 i386fbsd-nat.c
--- gdb/i386fbsd-nat.c 3 Jan 2009 05:57:52 -0000 1.16
+++ gdb/i386fbsd-nat.c 9 Feb 2009 12:32:57 -0000
@@ -125,6 +125,7 @@ _initialize_i386fbsd_nat (void)

/* Add some extra features to the common *BSD/i386 target. */
t = i386bsd_target ();
+ i386_use_watchpoints (t);
t->to_resume = i386fbsd_resume;
t->to_pid_to_exec_file = fbsd_pid_to_exec_file;
t->to_find_memory_regions = fbsd_find_memory_regions;

Pierre@d620-muller ~/gdbcvs/src
$ cvs diff -up gdb/i386* gdb/config/i386/nm-fbsd.h
Index: gdb/i386fbsd-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/i386fbsd-nat.c,v
retrieving revision 1.16
diff -u -p -r1.16 i386fbsd-nat.c
--- gdb/i386fbsd-nat.c 3 Jan 2009 05:57:52 -0000 1.16
+++ gdb/i386fbsd-nat.c 9 Feb 2009 12:33:18 -0000
@@ -125,6 +125,7 @@ _initialize_i386fbsd_nat (void)

/* Add some extra features to the common *BSD/i386 target. */
t = i386bsd_target ();
+ i386_use_watchpoints (t);
t->to_resume = i386fbsd_resume;
t->to_pid_to_exec_file = fbsd_pid_to_exec_file;
t->to_find_memory_regions = fbsd_find_memory_regions;
Index: gdb/config/i386/nm-fbsd.h
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/nm-fbsd.h,v
retrieving revision 1.18
diff -u -p -r1.18 nm-fbsd.h
--- gdb/config/i386/nm-fbsd.h 3 Jan 2009 05:57:54 -0000 1.18
+++ gdb/config/i386/nm-fbsd.h 9 Feb 2009 12:33:18 -0000
@@ -23,6 +23,7 @@

#ifdef HAVE_PT_GETDBREGS
#define I386_USE_GENERIC_WATCHPOINTS
+#define I386_WATCHPOINTS_IN_TARGET_VECTOR
#endif

#include "i386/nm-i386.h"