Re: [RFA] Use i386_use_watchpoints for go32v2, bds and windows native

Eli Zaretskii
2009-02-09T20:38:25Z

> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Cc: <gdb-patches@sourceware.org>
> Date: Mon, 9 Feb 2009 08:33:20 +0100
>
> The function i386_use_watchpoints
> simply sets the target vector fields related to hardware watchpoints.
> But this change alone is useless as the mechanism used to set
> hardware watchpoints in gdb relies on macros
> called target_insert_watchpoint or target_remove_watchpoint
> (plus others), macros that are set in nm-i386.h
> to call directly i386_insert_watchpoint/i386_remove_watchpoint,
> unless the macro I386_WATCHPOINTS_IN_TARGET_VECTOR is also
> defined when parsing that header.
>
> If target_xxx_watchpoint are set by nm-i386.h header,
> 'target remote' or 'target extended-remote' do not
> work as expected for remote hardware watchpoints because
> instead of calling remove_insert_watchpoint and similar,
> which generate the Z2 to Z4 packets, it still
> calls the native i386_insert_watchpoint.

Thanks. I'm okay with the changes to go32-nat.c and nm-go32.h.