Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Better realpath
Date: Sat, 14 Jun 2008 14:29:00 -0000	[thread overview]
Message-ID: <umylol0hq.fsf@gnu.org> (raw)
In-Reply-To: <200806141024.41812.vladimir@codesourcery.com>

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 14 Jun 2008 10:24:41 +0400
> 
> GDB has a function to get real path of a file, gdb_realpath. Unfortunately,
> that function is essentially a copy-paste of libiberty's lrealpath, with
> the extra bonus that gdb_realpath *does not* have any Windows-specific
> code. As result, GDB is not capable to simplify ".." in windows paths,
> and among other problems, breakpoints set using full file names containing
> ".." will not work.
> 
> This patch makes GDB use libibery's lrealpath. OK?

There were past discussions about this; please read them before
concluding that lrealpath is all we need.  My records seem to indicate
that a thread Re "fullname attribute for GDB/MI stack frames" in May
2005 on this list is one of them, but maybe there were more.  You will
find my critique of what lrealpath does on Windows in a message in
that thread I sent on May 29, and suggested ways to improve it in a
followup message on the same day.  I think if we are going to use
lrealpath, we should at least make its behavior consistent and correct
on all supported platforms, including native Windows (i.e. MinGW).


  parent reply	other threads:[~2008-06-14 11:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-14 11:09 Vladimir Prus
2008-06-14 11:30 ` Pierre Muller
2008-06-14 12:14   ` Vladimir Prus
2008-06-14 14:29 ` Eli Zaretskii [this message]
2008-06-14 15:10   ` Vladimir Prus
2008-06-14 22:05     ` Eli Zaretskii
2008-06-14 22:26       ` Vladimir Prus
2008-06-15 17:37         ` Eli Zaretskii
2008-06-15 17:43           ` Daniel Jacobowitz
2008-06-15 21:04             ` Eli Zaretskii
2008-06-16  3:17               ` Daniel Jacobowitz
2008-06-16  3:32                 ` Eli Zaretskii
2008-06-18 18:39               ` Stan Shebs
2008-06-18 20:47                 ` DJ Delorie
2008-06-18 15:22           ` Vladimir Prus
2008-06-18 21:08             ` Eli Zaretskii
2008-06-19  7:27               ` Vladimir Prus
2008-06-20  2:49                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=umylol0hq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox