From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30403 invoked by alias); 14 Jun 2008 11:30:07 -0000 Received: (qmail 30390 invoked by uid 22791); 14 Jun 2008 11:30:06 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout4.012.net.il (HELO mtaout4.012.net.il) (84.95.2.10) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 14 Jun 2008 11:29:46 +0000 Received: from HOME-C4E4A596F7 ([84.228.242.237]) by i_mtaout4.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K2G00LWGB7V44X0@i_mtaout4.012.net.il> for gdb-patches@sources.redhat.com; Sat, 14 Jun 2008 14:43:08 +0300 (IDT) Date: Sat, 14 Jun 2008 14:29:00 -0000 From: Eli Zaretskii Subject: Re: Better realpath In-reply-to: <200806141024.41812.vladimir@codesourcery.com> X-012-Sender: halo1@inter.net.il To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Reply-to: Eli Zaretskii Message-id: References: <200806141024.41812.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00260.txt.bz2 > From: Vladimir Prus > Date: Sat, 14 Jun 2008 10:24:41 +0400 > > GDB has a function to get real path of a file, gdb_realpath. Unfortunately, > that function is essentially a copy-paste of libiberty's lrealpath, with > the extra bonus that gdb_realpath *does not* have any Windows-specific > code. As result, GDB is not capable to simplify ".." in windows paths, > and among other problems, breakpoints set using full file names containing > ".." will not work. > > This patch makes GDB use libibery's lrealpath. OK? There were past discussions about this; please read them before concluding that lrealpath is all we need. My records seem to indicate that a thread Re "fullname attribute for GDB/MI stack frames" in May 2005 on this list is one of them, but maybe there were more. You will find my critique of what lrealpath does on Windows in a message in that thread I sent on May 29, and suggested ways to improve it in a followup message on the same day. I think if we are going to use lrealpath, we should at least make its behavior consistent and correct on all supported platforms, including native Windows (i.e. MinGW).