From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Vladimir Prus'" <vladimir@codesourcery.com>,
<gdb-patches@sources.redhat.com>
Subject: RE: Better realpath
Date: Sat, 14 Jun 2008 11:30:00 -0000 [thread overview]
Message-ID: <000001c8ce09$d121f430$7365dc90$@u-strasbg.fr> (raw)
In-Reply-To: <200806141024.41812.vladimir@codesourcery.com>
I just looked at your patch and the idea seems
good... But I am no expert on this field.
One question though, libiberty lrealpath
function uses strdup, while the replaced
code uses xstrdup.
xstrdup is also defined in libiberty
as being a replacement of strdup that never
fails... (didn't really get how this is
possible...)
Anyhow, is this a potential issue?
Pierre Muller
Pascal language support maintainer for GDB
-----Message d'origine-----
De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] De la part de Vladimir Prus
Envoyé : Saturday, June 14, 2008 8:25 AM
À : gdb-patches@sources.redhat.com
Objet : Better realpath
GDB has a function to get real path of a file, gdb_realpath. Unfortunately, that function is essentially a copy-paste of libiberty's lrealpath, with the extra bonus that gdb_realpath *does not* have any Windows-specific code. As result, GDB is not capable to simplify ".." in windows paths, and among other problems, breakpoints set using full file names containing ".." will not work.
This patch makes GDB use libibery's lrealpath. OK?
- Volodya
gdb/
* utils.c (gdb_realpath): Use lrealpath.
next prev parent reply other threads:[~2008-06-14 10:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 11:09 Vladimir Prus
2008-06-14 11:30 ` Pierre Muller [this message]
2008-06-14 12:14 ` Vladimir Prus
2008-06-14 14:29 ` Eli Zaretskii
2008-06-14 15:10 ` Vladimir Prus
2008-06-14 22:05 ` Eli Zaretskii
2008-06-14 22:26 ` Vladimir Prus
2008-06-15 17:37 ` Eli Zaretskii
2008-06-15 17:43 ` Daniel Jacobowitz
2008-06-15 21:04 ` Eli Zaretskii
2008-06-16 3:17 ` Daniel Jacobowitz
2008-06-16 3:32 ` Eli Zaretskii
2008-06-18 18:39 ` Stan Shebs
2008-06-18 20:47 ` DJ Delorie
2008-06-18 15:22 ` Vladimir Prus
2008-06-18 21:08 ` Eli Zaretskii
2008-06-19 7:27 ` Vladimir Prus
2008-06-20 2:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001c8ce09$d121f430$7365dc90$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox