From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31428 invoked by alias); 14 Jun 2008 10:31:56 -0000 Received: (qmail 31420 invoked by uid 22791); 14 Jun 2008 10:31:56 -0000 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 14 Jun 2008 10:31:36 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id m5EAVUV8039255 ; Sat, 14 Jun 2008 12:31:30 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402::142]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id m5EAVT1k065637 ; Sat, 14 Jun 2008 12:31:29 +0200 (CEST) Received: from d620muller ([130.79.244.152]) by mailserver.u-strasbg.fr (8.13.8/jtpda-5.5pre1) with ESMTP id m5EAVP0f008093 ; Sat, 14 Jun 2008 12:31:29 +0200 (CEST) From: "Pierre Muller" To: "'Vladimir Prus'" , References: <200806141024.41812.vladimir@codesourcery.com> In-Reply-To: <200806141024.41812.vladimir@codesourcery.com> Subject: RE: Better realpath Date: Sat, 14 Jun 2008 11:30:00 -0000 Message-ID: <000001c8ce09$d121f430$7365dc90$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (mailhost.u-strasbg.fr [IPv6:2001:660:2402::153]); Sat, 14 Jun 2008 12:31:30 +0200 (CEST) X-Virus-Status: Clean Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00258.txt.bz2 I just looked at your patch and the idea seems good... But I am no expert on this field. One question though, libiberty lrealpath function uses strdup, while the replaced=20 code uses xstrdup. xstrdup is also defined in libiberty as being a replacement of strdup that never fails... (didn't really get how this is possible...) Anyhow, is this a potential issue? Pierre Muller Pascal language support maintainer for GDB -----Message d'origine----- De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.= org] De la part de Vladimir Prus Envoy=C3=A9 : Saturday, June 14, 2008 8:25 AM =C3=80 : gdb-patches@sources.redhat.com Objet : Better realpath GDB has a function to get real path of a file, gdb_realpath. Unfortunately,= that function is essentially a copy-paste of libiberty's lrealpath, with t= he extra bonus that gdb_realpath *does not* have any Windows-specific code.= As result, GDB is not capable to simplify ".." in windows paths, and among= other problems, breakpoints set using full file names containing ".." will= not work. This patch makes GDB use libibery's lrealpath. OK? - Volodya gdb/ * utils.c (gdb_realpath): Use lrealpath.